Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Show Asset setting fields in translated view #692

Merged
merged 3 commits into from
Nov 22, 2023
Merged

chore: Show Asset setting fields in translated view #692

merged 3 commits into from
Nov 22, 2023

Conversation

utmishra
Copy link

  • The PR enables showForTranslation fields for all the blocks having Asset settings visible in the sidebar
  • Settings enabled::
Block name Enabled Setting 1 Enabled Setting 2 Enabled Setting 3
Template Template Input Template Preview Custom Preview
Image Image (from asset input) - -
Callout Icon Switch - -
Audio Audio (from asset input) - -
Compare Slider First Asset Second Asset -
Quote Quotation Marks - -

@utmishra utmishra requested a review from a team as a code owner November 21, 2023 16:23
@utmishra utmishra merged commit fd4bb6b into main Nov 22, 2023
10 checks passed
@utmishra utmishra deleted the chore/enable-asset-settings-for-translation branch November 22, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fulopdaniel fulopdaniel fulopdaniel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@utmishra @fulopdaniel