Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update guideline-blocks-settings/app-bridge #702

Merged
merged 27 commits into from
Jan 18, 2024
Merged

feat: update guideline-blocks-settings/app-bridge #702

merged 27 commits into from
Jan 18, 2024

Conversation

SamCreasey
Copy link
Contributor

@SamCreasey SamCreasey commented Jan 9, 2024 •
edited
Loading

Update the brand-sdk dependencies and also adjust Audio block and Image block to use the new attachments toolbar option.

@SamCreasey SamCreasey mentioned this pull request Jan 9, 2024
Merged
@SamCreasey SamCreasey changed the title [WIP] feat: update audio block toolbar feat: update audio block toolbar Jan 16, 2024
@SamCreasey SamCreasey marked this pull request as ready for review January 16, 2024 13:48
@SamCreasey SamCreasey requested a review from a team as a code owner January 16, 2024 13:48
@SamCreasey SamCreasey changed the title feat: update audio block toolbar feat: update guideline-blocks-settings Jan 17, 2024
@SamCreasey SamCreasey changed the title feat: update guideline-blocks-settings feat: update guideline-blocks-settings/fondue Jan 17, 2024
@SamCreasey SamCreasey changed the title feat: update guideline-blocks-settings/fondue feat: update guideline-blocks-settings/app-bridge Jan 17, 2024
@SamCreasey SamCreasey requested a review from ragi96 January 17, 2024 11:18
ragi96
ragi96 reviewed Jan 17, 2024
View reviewed changes
packages/audio-block/src/AudioBlock.tsx Outdated Show resolved Hide resolved
packages/image-block/src/ImageBlock.tsx Outdated Show resolved Hide resolved
packages/audio-block/src/components/AudioPlayer.tsx Outdated Show resolved Hide resolved
packages/audio-block/src/components/AudioPlayer.tsx Show resolved Hide resolved
@SamCreasey SamCreasey requested a review from ragi96 January 18, 2024 03:26
ragi96
ragi96 approved these changes Jan 18, 2024
View reviewed changes
Copy link
Collaborator

@ragi96 ragi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SamCreasey SamCreasey merged commit 04b5bc0 into main Jan 18, 2024
10 checks passed
@SamCreasey SamCreasey deleted the fix/audio-block-update branch January 18, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamuelAlev SamuelAlev SamuelAlev left review comments

@ragi96 ragi96 ragi96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SamCreasey @SamuelAlev @ragi96