Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(*): css scoping regex is incorrect #704

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Conversation

fulopdaniel
Copy link
Contributor

@fulopdaniel fulopdaniel commented Jan 11, 2024

  1. The CSS scoping postCSS plugin regex was wrong. Tailwind classes like bg-[rgb(150,150,150)] were wrongly prepended because of the commas. Updated the regex with a negative lookahead, to not prepend with the selector if the comma is escaped. (tailwind transforms classes like that to bg-[rgb(150\,150\,150)]).

@fulopdaniel fulopdaniel marked this pull request as ready for review January 11, 2024 11:02
@fulopdaniel fulopdaniel requested a review from a team as a code owner January 11, 2024 11:02
@fulopdaniel fulopdaniel force-pushed the fix/css-scope-improvement branch from c6553ca to d4fb743 Compare January 11, 2024 13:29
Copy link
Collaborator

@ragi96 ragi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fulopdaniel fulopdaniel merged commit ca34619 into main Jan 11, 2024
10 checks passed
@fulopdaniel fulopdaniel deleted the fix/css-scope-improvement branch January 11, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants