Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DoDontBlock): performance improvement #781

Merged
merged 6 commits into from
Mar 13, 2024

Conversation

fulopdaniel
Copy link
Contributor

@fulopdaniel fulopdaniel commented Mar 11, 2024

  1. Make one block assets request and pass down to items
  2. Change updateAssetIdsFromKey to addAssetIdsToKey or deleteAssetIdsFromKey
  3. Improve DnD Sort context: prevent thousands of rerenders when dragging is active. Every px change resulted in rerendering the whole tree.
  4. Extend ResponsiveImage with classname and style to make it more customisable.
  5. Patch pnpm dependency like in brand-sdk, otherwise vite tests don't run

Waiting for feedback on whether we should turn the image mode on in settings.ts

@fulopdaniel fulopdaniel requested a review from SamCreasey March 12, 2024 07:53
@SamCreasey
Copy link
Contributor

Screenshot 2024-03-12 at 18 04 56 Each do and don't item updates if you type into any RTE. Wrapping the item in memo is not doing anything right now. We should make sure these props are stable

@fulopdaniel fulopdaniel marked this pull request as ready for review March 12, 2024 14:27
@fulopdaniel fulopdaniel requested a review from a team as a code owner March 12, 2024 14:27
@fulopdaniel fulopdaniel requested a review from SamCreasey March 12, 2024 14:27
@fulopdaniel fulopdaniel merged commit b3fb348 into main Mar 13, 2024
10 checks passed
@fulopdaniel fulopdaniel deleted the feat/do-dont-perf-improvements branch March 13, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants