Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(CalloutBlock): unregister assets on switch off #974

Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix(CalloutBlock): unregister assets on switch off #974

merged 2 commits into from
Dec 5, 2024

Conversation

fulopdaniel
Copy link
Contributor

@fulopdaniel fulopdaniel commented Dec 5, 2024 •
edited
Loading

Quote blocks: #975

@fulopdaniel fulopdaniel requested a review from ragi96 December 5, 2024 12:17
@fulopdaniel fulopdaniel requested a review from a team as a code owner December 5, 2024 12:17
ragi96
ragi96 approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@ragi96 ragi96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fulopdaniel fulopdaniel merged commit 53f5630 into main Dec 5, 2024
10 checks passed
@fulopdaniel fulopdaniel deleted the TASK-13146_-Callout-Block-Custom-Icon-does-not-get-deleted--unregistered-when-toggling-off_Daniel-Fulop branch December 5, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ragi96 ragi96 ragi96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fulopdaniel @ragi96