Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boilermaker updates #168

Merged
4 commits merged into from
Apr 10, 2019
Merged

Boilermaker updates #168

4 commits merged into from
Apr 10, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 9, 2019

Assignee Tasks

  • Updated a bunch of the packages

Guidelines

It has been a while since the boilermaker repo has been updated so there were a few security vulnerabilities generated from lack of updates. I did avoid updating react-redux until I tested a few things in projects because it has been known to have some issues with versioning against other react- modules.


From Slack Academics Slack Channel: "I went through each package its dependency tree almost all manually to avoid updating things that don't need to be updated. So, I followed a format like given X.Y.Z, if X (major) was not on the correct number, it was updated, and if Y (minor) was like something larger, it was updated. Z (patches) wasn't really touched."

@collin
Copy link
Contributor

collin commented Apr 9, 2019

At face value this seems like a Good Thing™️©2019.

Might be worth sending this to a few fellows to try and run against their grace shopper projects to see if anything breaks in an obvious way.

@glebec
Copy link
Member

glebec commented Apr 9, 2019

Related to #165

b17z and others added 2 commits April 10, 2019 10:52
redux logger has changed their export strategy
@leafoflegend
Copy link

@b17z-fsa I tested this out locally last night in some free time and the commands all seemed to work as expected. It would be nice if you are introducing a change log to maybe automate some aspect of the change log or change CI to expect it? Thats really my only comment.

I didn't heavily test it however and agree with #168 (comment) that having fellows give this a more thorough test could be worthwhile.

Copy link
Contributor

@collin collin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I applied this to an existing grace-shopper project and got this error message in my console:

[redux-logger v3] BREAKING CHANGE
[redux-logger v3] Since 3.0.0 redux-logger exports by default logger with default settings.
[redux-logger v3] Change
[redux-logger v3] import createLogger from 'redux-logger'
[redux-logger v3] to
[redux-logger v3] import { createLogger } from 'redux-logger'

Added a commit to address that.

@ghost
Copy link
Author

ghost commented Apr 10, 2019

@leafoflegend Yeah, I can do that. I should have done that and will do that a bit later.
@collin Thanks for confirming/testing. I was having a few of the fellows look at it.

@ghost ghost merged commit cd9fd0e into master Apr 10, 2019
@collin collin deleted the boilermaker-updates branch April 10, 2019 16:30
EthanG19 pushed a commit to D3Doritos/AllSign that referenced this pull request Nov 26, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants