-
Notifications
You must be signed in to change notification settings - Fork 706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boilermaker updates #168
Boilermaker updates #168
Conversation
At face value this seems like a Might be worth sending this to a few fellows to try and run against their grace shopper projects to see if anything breaks in an obvious way. |
Related to #165 |
redux logger has changed their export strategy
@b17z-fsa I tested this out locally last night in some free time and the commands all seemed to work as expected. It would be nice if you are introducing a change log to maybe automate some aspect of the change log or change CI to expect it? Thats really my only comment. I didn't heavily test it however and agree with #168 (comment) that having fellows give this a more thorough test could be worthwhile. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied this to an existing grace-shopper project and got this error message in my console:
[redux-logger v3] BREAKING CHANGE
[redux-logger v3] Since 3.0.0 redux-logger exports by default logger with default settings.
[redux-logger v3] Change
[redux-logger v3] import createLogger from 'redux-logger'
[redux-logger v3] to
[redux-logger v3] import { createLogger } from 'redux-logger'
Added a commit to address that.
@leafoflegend Yeah, I can do that. I should have done that and will do that a bit later. |
…aker-updates Boilermaker updates
Assignee Tasks
Guidelines
It has been a while since the boilermaker repo has been updated so there were a few security vulnerabilities generated from lack of updates. I did avoid updating react-redux until I tested a few things in projects because it has been known to have some issues with versioning against other react- modules.
From Slack Academics Slack Channel: "I went through each package its dependency tree almost all manually to avoid updating things that don't need to be updated. So, I followed a format like given X.Y.Z, if X (major) was not on the correct number, it was updated, and if Y (minor) was like something larger, it was updated. Z (patches) wasn't really touched."