Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jd/map->Properties on kafka-streams opts #253

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

madstap
Copy link
Contributor

@madstap madstap commented Jun 3, 2020

This seems like an oversight, I found it confusing that I had to use string keys.

Checklist

Not sure how to go about testing this?

  • tests
  • updated CHANGELOG (the "unreleased" section)

@madstap madstap requested a review from a team as a code owner June 3, 2020 15:15
@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #253 into master will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   81.16%   81.25%   +0.08%     
==========================================
  Files          41       41              
  Lines        2586     2560      -26     
  Branches      153      149       -4     
==========================================
- Hits         2099     2080      -19     
+ Misses        334      331       -3     
+ Partials      153      149       -4     
Impacted Files Coverage Δ
src/jackdaw/streams.clj 82.92% <100.00%> (-0.28%) ⬇️
src/jackdaw/test/commands/write.clj 92.85% <0.00%> (-0.33%) ⬇️
src/jackdaw/test/serde.clj 94.52% <0.00%> (-0.08%) ⬇️
src/jackdaw/test/transports/rest_proxy.clj 84.61% <0.00%> (-0.08%) ⬇️
src/jackdaw/test/transports/kafka.clj 86.04% <0.00%> (+0.43%) ⬆️
src/jackdaw/test/transports/mock.clj 84.48% <0.00%> (+2.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daa8387...c050c83. Read the comment docs.

@cddr
Copy link
Contributor

cddr commented Aug 5, 2020

LGTM. The existing integration tests should cover this change.

e.g. this one which uses the kafka-streams function through the test fixture https://github.com/FundingCircle/jackdaw/blob/master/test/jackdaw/test/transports/kafka_test.clj#L54

cddr
cddr previously approved these changes Aug 5, 2020
@madstap
Copy link
Contributor Author

madstap commented Oct 14, 2020

Is there anything missing on my end for getting this PR merged?

@madstap
Copy link
Contributor Author

madstap commented Sep 13, 2021

I suppose this isn't really high priority, but the PR has seen it's first birthday already. Any hope of getting it merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants