-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use jd/map->Properties on kafka-streams opts #253
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
==========================================
+ Coverage 81.16% 81.25% +0.08%
==========================================
Files 41 41
Lines 2586 2560 -26
Branches 153 149 -4
==========================================
- Hits 2099 2080 -19
+ Misses 334 331 -3
+ Partials 153 149 -4
Continue to review full report at Codecov.
|
LGTM. The existing integration tests should cover this change. e.g. this one which uses the |
Is there anything missing on my end for getting this PR merged? |
I suppose this isn't really high priority, but the PR has seen it's first birthday already. Any hope of getting it merged? |
This seems like an oversight, I found it confusing that I had to use string keys.
Checklist
Not sure how to go about testing this?