Enable naming global-ktable local store #277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #277 +/- ##
==========================================
+ Coverage 81.16% 81.20% +0.03%
==========================================
Files 41 41
Lines 2586 2596 +10
Branches 153 153
==========================================
+ Hits 2099 2108 +9
- Misses 334 335 +1
Partials 153 153
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation doesn't support naming the GlobalKTable store. This pull request adds functionality by extending the protocol IStreamsBuilder and adding a new arity to the existing global-ktable function. Implementation follows the same pattern used to name ktable local stores.