[BUGFIX] Fix Combo Drop animations when missing notes or dropping hold notes #4968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
pr: haxe
Hundrec
added
type: minor bug
|
Nice and simple! |
EliteMasterEric
added
size: small
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
Fixes #4964
Briefly describe the issue(s) fixed.
The girlfriend character would not play the combo drop animation if the note was completely missed or if a hold note was dropped. This happened because the events weren't being sent the correct current combo count. The note miss event was always sending a value of 0 for the current combo count, while the hold note event didn't have a parameter to send the combo count.
This PR fixes this issue for note misses by sending the current combo count into the note miss event instead of 0. For hold notes,
comboCountwas added as a parameter to the script event, and the current combo count is passed into it when a hold note is dropped.Include any relevant screenshots or videos.
Missing a note:
note-miss.mp4
Dropping a hold note:
hold-note-drop.mp4