Skip to content

Redo beat and step display #4994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

NotHyper-474
Copy link
Contributor

@NotHyper-474 NotHyper-474 commented May 4, 2025

Does this PR close any issues? If so, link them below.

No.

Briefly describe the issue(s) fixed.

I feel like the current way they're displayed is not consistent with the rest of the playbar so I've added separate labels for them rather than reusing the song position text.

Important

Requires FunkinCrew/funkin.assets#184

Include any relevant screenshots or videos.

image

@github-actions github-actions bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. and removed status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. labels May 4, 2025
@AbnormalPoof AbnormalPoof added type: enhancement Involves an enhancement or new feature. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. size: medium A medium pull request with 100 or fewer changes. labels May 4, 2025
@Hundrec
Copy link
Collaborator

Hundrec commented May 4, 2025

So clean, so nice

Copy link
Contributor

@Lasercar Lasercar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OCD fix

@EliteMasterEric EliteMasterEric added size: medium A medium pull request with 100 or fewer changes. and removed size: medium A medium pull request with 100 or fewer changes. labels May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. topic: chart editor Related to the operation of the Chart Editor. type: enhancement Involves an enhancement or new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants