[ENHANCEMENT?] Have FNFLegacyImporter better rebuild legacy events and time changes on charts #5021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
status: pending triage
AbnormalPoof
added
type: enhancement
EliteMasterEric
added
size: medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR close any issues? If so, link them below.
i dont think so, but just a tiny issue i noticed :D
Briefly describe the issue fixed.
FNFLegacyImporter would insert camera events and time changes at the first note time position of that section, but if section had no notes those events would be lost, or be at the wrong time if the note wasnt at the exact start of that section, messing with conductor and camera event timing.
Simulates the way legacy conductor would find the time of these events to convert chart to vslice.
Include any relevant screenshots or videos.
(too slow encore as example idk many songs with tempo change stuff)
legacyimportfixtest.mp4