Orientation error, add covariance as parameters, parameter for frame_id #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tried to run this version. Wasn't able to get it running at all even making a couple changes. |
Was this written for bno085? I am using bno080, took out all calibration related code from talker.py and it ran correctly. Data looks better as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed that orientation space was wrong. I had to fix this by change the value assignemnt on quaternions.Also I added covariances as parameters. I'm not sure what is the correct covariance matrix for this device, but it can now be set via parameters. So we can test different values to see without compiling it again.
Last thing I did was adding a parameter for frame_id
BR Patrick