Skip to content

[Slider] Fix slider disappearance when the minimum value is set to 1. #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2023
Merged

[Slider] Fix slider disappearance when the minimum value is set to 1. #785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
188 changes: 126 additions & 62 deletions extensions/reviewed/PanelSpriteSlider.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"name": "PanelSpriteSlider",
"previewIconUrl": "https://asset-resources.gdevelop.io/public-resources/Icons/Line Hero Pack/Master/SVG/UI Essentials/1678c39a3b2bd3df4f82a8a293770db4986a6bcfd3f78e738ddfc86e39176423_UI Essentials_sliders_options.svg",
"shortDescription": "A draggable slider that users can move to select a numerical value.",
"version": "1.4.0",
"version": "1.4.1",
"description": [
"A draggable slider that users can move to select a numerical value. The slider can be customized with sprites.",
"",
Expand Down Expand Up @@ -221,6 +221,18 @@
"=",
"GetArgumentAsNumber(\"Value\")"
]
},
{
"type": {
"value": "PanelSpriteSlider::Slider::SetValue"
},
"parameters": [
"Object",
"Behavior",
"=",
"Object.Behavior::Value()",
""
]
}
]
}
Expand Down Expand Up @@ -302,6 +314,18 @@
"=",
"GetArgumentAsNumber(\"Value\")"
]
},
{
"type": {
"value": "PanelSpriteSlider::Slider::SetValue"
},
"parameters": [
"Object",
"Behavior",
"=",
"Object.Behavior::Value()",
""
]
}
]
}
Expand All @@ -322,11 +346,11 @@
"objectGroups": []
},
{
"description": "Return the bar value bounds size.",
"description": "the bar value bounds size.",
"fullName": "Size",
"functionType": "Expression",
"functionType": "ExpressionAndCondition",
"name": "Size",
"sentence": "",
"sentence": "the bar value bounds size",
"events": [
{
"type": "BuiltinCommonInstructions::Standard",
Expand Down Expand Up @@ -423,6 +447,18 @@
"=",
"GetArgumentAsNumber(\"Value\")"
]
},
{
"type": {
"value": "PanelSpriteSlider::Slider::SetValue"
},
"parameters": [
"Object",
"Behavior",
"=",
"Object.Behavior::Value()",
""
]
}
]
}
Expand Down Expand Up @@ -2162,6 +2198,14 @@
{
"type": "BuiltinCommonInstructions::Standard",
"conditions": [
{
"type": {
"value": "PanelSpriteSlider::PanelSpriteSlider::PropertyShowLabelAtChanges"
},
"parameters": [
"Object"
]
},
{
"type": {
"value": "CollisionPoint"
Expand Down Expand Up @@ -3074,78 +3118,98 @@
"events": [
{
"type": "BuiltinCommonInstructions::Standard",
"conditions": [],
"actions": [
"conditions": [
{
"type": {
"value": "PanelSpriteObject::Width"
"value": "PanelSpriteSlider::Slider::Size"
},
"parameters": [
"FillBar",
"=",
"Object.FullBarWidth() * (FillBar.Slider::Value() - FillBar.Slider::MinValue()) / FillBar.Slider::Size()"
]
}
]
},
{
"type": "BuiltinCommonInstructions::Standard",
"conditions": [],
"actions": [
{
"type": {
"value": "SetCenterX"
},
"parameters": [
"Thumb",
"=",
"Object.FullBarLeft() + FillBar.Width()"
]
},
{
"type": {
"value": "SetCenterY"
},
"parameters": [
"Thumb",
"=",
"FillBar.CenterY()"
"Slider",
">",
"0",
""
]
}
]
},
{
"type": "BuiltinCommonInstructions::Standard",
"conditions": [],
"actions": [
],
"actions": [],
"events": [
{
"type": {
"value": "TextObject::String"
},
"parameters": [
"Label",
"=",
"ToString(Object.Value())"
"type": "BuiltinCommonInstructions::Standard",
"conditions": [],
"actions": [
{
"type": {
"value": "PanelSpriteObject::Width"
},
"parameters": [
"FillBar",
"=",
"Object.FullBarWidth() * (FillBar.Slider::Value() - FillBar.Slider::MinValue()) / FillBar.Slider::Size()"
]
}
]
},
{
"type": {
"value": "SetCenterX"
},
"parameters": [
"Label",
"=",
"Thumb.CenterX()"
"type": "BuiltinCommonInstructions::Standard",
"conditions": [],
"actions": [
{
"type": {
"value": "SetCenterX"
},
"parameters": [
"Thumb",
"=",
"Object.FullBarLeft() + FillBar.Width()"
]
},
{
"type": {
"value": "SetCenterY"
},
"parameters": [
"Thumb",
"=",
"FillBar.CenterY()"
]
}
]
},
{
"type": {
"value": "MettreY"
},
"parameters": [
"Label",
"=",
"Thumb.Y() - Label.Height() - Object.PropertyLabelMargin()"
"type": "BuiltinCommonInstructions::Standard",
"conditions": [],
"actions": [
{
"type": {
"value": "TextObject::String"
},
"parameters": [
"Label",
"=",
"ToString(Object.Value())"
]
},
{
"type": {
"value": "SetCenterX"
},
"parameters": [
"Label",
"=",
"Thumb.CenterX()"
]
},
{
"type": {
"value": "MettreY"
},
"parameters": [
"Label",
"=",
"Thumb.Y() - Label.Height() - Object.PropertyLabelMargin()"
]
}
]
}
]
Expand Down