Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CF-665 Add alternative messaging provider #980

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CF-665 Add alternative messaging provider #980

wants to merge 2 commits into from
+9 −2

Conversation

thoagb
Copy link
Contributor

@thoagb thoagb commented Feb 28, 2025

No description provided.

drocek
drocek reviewed Feb 28, 2025
View reviewed changes
.../main/java/com/generalbytes/batm/server/extensions/communication/ICommunicationProvider.java Outdated
@@ -20,6 +20,7 @@

/**
* Provider for sending sms.
* For alternative provider (e.g. WhatsApp) implement {@link IMessagingProvider} instead
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing dot at end of line.

drocek
drocek reviewed Feb 28, 2025
View reviewed changes
.../src/main/java/com/generalbytes/batm/server/extensions/communication/IMessagingProvider.java Outdated
String getCtaButtonText(Locale locale);

/**
* Gets the resource path of the CTA button icon.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also add info about what CTA means to this Javadoc, just in case I read the documentation for just this method from another place.

@thoagb thoagb changed the title CF-665 Add alternative messaging provider DRAFT: CF-665 Add alternative messaging provider Feb 28, 2025
@thoagb thoagb marked this pull request as draft February 28, 2025 11:23
@thoagb thoagb force-pushed the feature/CF-665-alternative-messaging-provider branch from dd5e2a0 to 2f3b2e9 Compare March 3, 2025 11:21
@thoagb thoagb changed the title DRAFT: CF-665 Add alternative messaging provider CF-665 Add alternative messaging provider Mar 3, 2025
@thoagb thoagb marked this pull request as ready for review March 3, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drocek drocek drocek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thoagb @drocek