Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#914 specify level orientation #941

Merged
merged 3 commits into from
Jul 30, 2021

Conversation

bena-nasa
Copy link
Collaborator

This addresses #914
The GCHP users requested the ability to flip the native output relative to the input. It was agreed that for now we will assume History always gets fields "down" in that level 1 is the top of the atmosphere. This is true in GEOS and in GCHP they adjust the inputs to History so the is the case. However, they were requesting that it would be nice if you could get output from History that conforms to the GCHP convention that level 1 is the surface so it would be less confusing for users.
This PR adds a 'positive' option to the history collection. By default it is 'down' and the only other allowed option is 'up'. If you specify any "levels" either to select model levels to regrid to pressure, height etc ... this is ignored, so only used if you are specifying full native level output. We assume all 3D fields coming to history will be 'down' as in GEOS and so by default nothing is done. If you specify 'up' the positive attribute in the output is now 'up' and the levels will be flipped relative to what came into History.

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Trivial change (affects only documentation or cleanup)

Checklist:

  • I have tested this change with a run of GEOSgcm (if non-trivial)
  • I have added one of the required labels (0 diff, 0 diff trivial, 0 diff structural, non 0-diff)
  • I have updated the CHANGELOG.md accordingly following the style of Keep a Changelog

@bena-nasa bena-nasa requested a review from a team as a code owner July 30, 2021 14:42
@bena-nasa bena-nasa added 0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature labels Jul 30, 2021
@tclune tclune merged commit 14f91e7 into develop Jul 30, 2021
@bena-nasa bena-nasa deleted the feature/bmauer/#914_specify_level_orientation branch July 30, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 Diff The changes in this pull request have verified to be zero-diff with the target branch. 🎁 New Feature This is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants