Skip to content

GPII-4517: Added workflow for github actions #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

javihernandez
Copy link
Member

@javihernandez javihernandez commented Nov 16, 2020

run: npx grunt lint

- name: Run node unit tests
run: node tests/UnitTests.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth trying a few acceptance tests? Do they run?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They would run, but if we want to run them as they are we'd need to set up couchdb. I can definitely take a look if there's an easy way to set up couchdb in the github-hosted windows images. I think I can even take a look at creating a small github action that sets up couchdb on windows (I already did something similar for our vagrant boxes), but again, I'd need some time.

Another option would be to run the acceptanceTests against a file-based prefsServer, which I think it's not the way we want to test things.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So yeah, let me give a try at setting up couchdb, I'll keep you posted 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json Outdated
@@ -19,7 +19,7 @@
"dependencies": {
"edge-js": "10.3.1",
"ffi-napi": "2.4.3",
"gpii-universal": "0.3.0-dev.20200604T131823Z.d6fed9a",
"gpii-universal": "javihernandez/universal#f2972b9deeae48847a4ed951d1ab703b4e7bafc5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which commit is this - should we roll a release of it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, the universal bits are in this PR GPII/universal#886
So let's say this PR needs that one the get merged first

@javihernandez
Copy link
Member Author

@amb26
Copy link
Member

amb26 commented Nov 23, 2020

What's the state of the CI at this end? I see a "Pending - Build triggered" note from the bot, but I assume this form of CI is gone. What's required to get the github actions CI as the official one for this repo?

@javihernandez
Copy link
Member Author

Yes, this is the old CI, which is gone now. I already checked that further PRs won't trigger any job into the old CI, see #330

After merging this PR, the tests will run on github actions with every new PR and whenever a new commit lands into master. All CI passes will appear in https://github.com/GPII/windows/actions as soon as this is merged as it happened in universal, see https://github.com/GPII/universal/actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants