Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add thumbs toggle #8

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

varzaman
Copy link

Changed the css so if #player had a thumbs attribute, it would hide the shuffle and repeat icons and show the thumbs instead.

@MarshallOfSound
Copy link
Member

There is no reason why we can't have an API inside this library to toggle that thumbs attribute.

Some sample code would be inserted into https://github.com/GPMDP/gmusic-mini-player.js/blob/master/src/gmusic-mini-player.js#L181

showsThumbAlways: (always) => {
    const player = document.getElementById('player');
    if (always) {
        player.setAttribute('thumbs', true);
    } else {
        player.removeAttribute('thumbs');
    }
},

@Pluckerpluck
Copy link

So is this feature just sitting dead in the water? I've just found GPMDP, and this one aspect is the only minor annoyance I have with it.

It's only really an issue when I sometimes throw on something like the top 50, but mostly I just want to see if I've already thumed up songs every now and then.

@Noxxys
Copy link

Noxxys commented Jun 28, 2018

I would also love to have thumb up/down buttons on the mini player, I use it a lot more than repeat / shuffle. To display all of them, we could make the button smaller, or display thumb up/down on mouse over in the middle.

My use case: I have the mini player always-on-top in a corner of one of my screen and I would like to thumb up/down from there. I could thumb up/down from the systray icon. but I can't see if it's already thumbed up or not from there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants