Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement new layout on login page #405

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

jfredrickson
Copy link
Contributor

No description provided.

@jfredrickson
Copy link
Contributor Author

jfredrickson commented Mar 13, 2025

Sidebar gray issue seems due to bg-gray-50 in USWDS meaning a darker gray than Tailwind's bg-gray-50. However, I'm not sure why USWDS styles are spilling over into the main layout when I thought they should be confined to the components they're used in, which appear only on the login page.

If you refresh the page after logging in, the incorrect sidebar background color disappears.

Should be fixed now!

@jfredrickson jfredrickson requested a review from echappen March 18, 2025 19:44
@jfredrickson
Copy link
Contributor Author

Not loving the way this manages USWDS static assets, but it seems to be necessary to prevent the more serious conflicts between Tailwind and USWDS.

@echappen
Copy link
Contributor

[Non-blocking suggestion] For the stylesheet link in src/routes/auth/page.svelte, might it be worth using the minified css file of USWDS (uswds.min.css), at least in production? We have it in the same directory as the current file.

@echappen
Copy link
Contributor

[blocking observation] This is what I'm seeing in Dark Mode: the background remains white, but the instructional text is blurred and only one of the text inputs gets a border. I suppose the white bg would be fine if we un-blur the text and put borders around both inputs?

Screenshot 2025-03-18 at 4 34 14 PM

@echappen
Copy link
Contributor

Blur's the wrong word... the text just becomes a very light gray.

@jfredrickson
Copy link
Contributor Author

I don't want to sear any eyeballs, so a legit dark implementation for the login page would be good. USWDS doesn't have a dark mode out of the box, so let me see what I can come up with. Good catch on the minified uswds.min.css, forgot to switch over to that one.

@echappen
Copy link
Contributor

@vickimcfadden @actuallyjenn See discussion above—should dark mode styling block merging? Otherwise this looks gtg.

@jimmoffet
Copy link
Contributor

@vickimcfadden @actuallyjenn See discussion above—should dark mode styling block merging? Otherwise this looks gtg.

I think something like 80%+ of mobile users keep dark mode on full time. Can't find great stats for desktop, but I think we should assume that many, if not most, users will see it.

@vickimcfadden
Copy link

@jimmoffet @jfredrickson @echappen yea, this seems like a blocker – let's update!

@jfredrickson
Copy link
Contributor Author

I tore out USWDS and simply reimplemented the appearance using Tailwind classes. This allowed more straightforward implementation of dark mode. I think we need to revisit the use of USWDS separately later on.

@jfredrickson jfredrickson changed the title implement USWDS on login page implement new layout on login page Mar 19, 2025
@jfredrickson
Copy link
Contributor Author

@echappen I think this should be ready for another review now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants