-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement new layout on login page #405
base: main
Are you sure you want to change the base?
Conversation
Should be fixed now! |
Not loving the way this manages USWDS static assets, but it seems to be necessary to prevent the more serious conflicts between Tailwind and USWDS. |
[Non-blocking suggestion] For the stylesheet link in |
Blur's the wrong word... the text just becomes a very light gray. |
I don't want to sear any eyeballs, so a legit dark implementation for the login page would be good. USWDS doesn't have a dark mode out of the box, so let me see what I can come up with. Good catch on the minified |
@vickimcfadden @actuallyjenn See discussion above—should dark mode styling block merging? Otherwise this looks gtg. |
I think something like 80%+ of mobile users keep dark mode on full time. Can't find great stats for desktop, but I think we should assume that many, if not most, users will see it. |
@jimmoffet @jfredrickson @echappen yea, this seems like a blocker – let's update! |
I tore out USWDS and simply reimplemented the appearance using Tailwind classes. This allowed more straightforward implementation of dark mode. I think we need to revisit the use of USWDS separately later on. |
@echappen I think this should be ready for another review now. |
No description provided.