Skip to content

Commit

Permalink
Revert Node 23 to Node 20 (#4680)
Browse files Browse the repository at this point in the history
* Revert node 23 to node 20

* Dockerfile Node 23 to 20
  • Loading branch information
jperson1 authored Jan 30, 2025
1 parent 19ca2fd commit 810879c
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cypress-testing-from-container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 23
node-version: 20

- name: Install Node dependencies
working-directory: ./backend
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/testing-from-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: 23
node-version: 20

- name: Create .env
working-directory: ./backend
Expand Down Expand Up @@ -81,7 +81,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 23
node-version: 20

- name: Install Node dependencies
working-directory: ./backend
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/testing-from-ghcr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: 23
node-version: 20

- name: Create .env file
working-directory: ./backend
Expand Down Expand Up @@ -83,7 +83,7 @@ jobs:
- name: Setup Node
uses: actions/setup-node@v4
with:
node-version: 23
node-version: 20

- name: Install Node dependencies
working-directory: ./backend
Expand Down
2 changes: 1 addition & 1 deletion backend/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ RUN set -ex && \
FROM pip AS node
WORKDIR /src/

RUN curl -fsSL https://deb.nodesource.com/setup_23.x | bash - && \
RUN curl -fsSL https://deb.nodesource.com/setup_20.x | bash - && \
apt-get install -y nodejs
COPY package*.json /src/
RUN npm ci && \
Expand Down
2 changes: 1 addition & 1 deletion backend/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion backend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"main": "index.js",
"engines": {
"npm": ">=9.0.0",
"node": ">=18.0.0 <=23.6.1"
"node": ">=18.0.0 <21.0.0"
},
"scripts": {
"build": "run-p build:*",
Expand Down

0 comments on commit 810879c

Please sign in to comment.