Fix duplicate report_id generation

[rnovak338]

Addresses #4638.

This PR is expected to fix the following error that appears for POST /report_submission/accessandsubmission:

django.db.utils.IntegrityError: duplicate key value violates unique constraint "audit_singleauditchecklist_report_id_key"\nDETAIL: Key (report_id)=(YYYY-MM-GSAFAC-XXXXXXXXXX) already exists.

Our routine for generating report_id takes the audit date and the total count of SingleAuditChecklist + 1. The total count is appearing to return a number on creation of a new SAC that is already tied to an existing report_id in the database. My suspicion is that our current logic allows for the race condition.

In theory, two SACs (with the same audit year and month) could be created at the same time and attempt to pull the same "count" when generating the report_id. See this document for reference.

How to test

Step 1 - Prepare race condition check

Inside backend/report_submission/views.py, insert the following method:

def simulate_delay(instance, duration):
    running_version = os.getenv("FAC_INSTANCE_NAME")
    if running_version == instance:
        logger.info("{} sleeping for {}s".format(running_version, duration))
        time.sleep(duration)
    else:
        logger.info("{} continuing...".format(running_version))

At the start of the transaction.atomic() block in the post method of AccessAndSubmissionFormView, replace:

result = api.views.access_and_submission_check(request.user, request.POST)

with this block:

simulate_delay("web1", 20)
result = api.views.access_and_submission_check(request.user, request.POST)
print("Input:")
print(dict(request.POST.items()))
print("Result:")
print(result)

Step 2 - Test the race condition

1. Start up the application as two instances using the below command. You should be able to boot up two instances of the local enviroment: localhost:8000 and localhost:8001. Have them up as separate tabs.

   docker-compose -f docker-compose-dual-fac.yml up
   
2. Log in to both instances, and go through the process of creating a new SAC, UP to step 3. Do not create the audit for either tab.
3. Once both tabs have completed form data and you are ready to submit for both, press the submit button for localhost:8000 and then localhost:8001 in quick succession. Both buttons should be grayed out as soon as they are clicked. This prevents double-clicks.
4. The first application should proceed to the next step successfully, and the second application will reload the page as an error after a 20 second delay.
   • FYI, this does not feel intuitive, but it at least prevents the 500 error from occurring and duplicate audits from being created.

PR Checklist: Submitter

• Link to an issue if possible. If there’s no issue, describe what your branch does. Even if there is an issue, a brief description in the PR is still useful.
• List any special steps reviewers have to follow to test the PR. For example, adding a local environment variable, creating a local test file, etc.
• For extra credit, submit a screen recording like this one.
• Make sure you’ve merged main into your branch shortly before creating the PR. (You should also be merging main into your branch regularly during development.)
• Make sure you’ve accounted for any migrations. When you’re about to create the PR, bring up the application locally and then run git status | grep migrations. If there are any results, you probably need to add them to the branch for the PR. Your PR should have only one new migration file for each of the component apps, except in rare circumstances; you may need to delete some and re-run python manage.py makemigrations to reduce the number to one. (Also, unless in exceptional circumstances, your PR should not delete any migration files.)
• Make sure that whatever feature you’re adding has tests that cover the feature. This includes test coverage to make sure that the previous workflow still works, if applicable.
• Make sure the full-submission.cy.js Cypress test passes, if applicable.
• Do manual testing locally. Our tests are not good enough yet to allow us to skip this step. If that’s not applicable for some reason, check this box.
• Verify that no Git surgery was necessary, or, if it was necessary at any point, repeat the testing after it’s finished.
• Once a PR is merged, keep an eye on it until it’s deployed to dev, and do enough testing on dev to verify that it deployed successfully, the feature works as expected, and the happy path for the broad feature area (such as submission) still works.
• Ensure that prior to merging, the working branch is up to date with main and the terraform plan is what you expect.

PR Checklist: Reviewer

• Pull the branch to your local environment and run make docker-clean; make docker-first-run && docker compose up; then run docker compose exec web /bin/bash -c "python manage.py test"
• Manually test out the changes locally, or check this box to verify that it wasn’t applicable in this case.
• Check that the PR has appropriate tests. Look out for changes in HTML/JS/JSON Schema logic that may need to be captured in Python tests even though the logic isn’t in Python.
• Verify that no Git surgery is necessary at any point (such as during a merge party), or, if it was, repeat the testing after it’s finished.

The larger the PR, the stricter we should be about these points.

Pre Merge Checklist: Merger

• Ensure that prior to approving, the terraform plan is what we expect it to be. -/+ resource "null_resource" "cors_header" should be destroying and recreating its self and ~ resource "cloudfoundry_app" "clamav_api" might be updating its sha256 for the fac-file-scanner and fac-av-${ENV} by default.
• Ensure that the branch is up to date with main.
• Ensure that a terraform plan has been recently generated for the pull request.

[github-actions]

Terraform plan for meta

No changes. Your infrastructure matches the configuration.

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

✅ Plan applied in Deploy to Development and Management Environment #947

[github-actions]

Terraform plan for dev

Plan: 1 to add, 3 to change, 1 to destroy.

Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
!~  update in-place
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.dev.cloudfoundry_app.postgrest will be updated in-place
!~  resource "cloudfoundry_app" "postgrest" {
!~      docker_image                    = "ghcr.io/gsa-tts/fac/postgrest@sha256:7d69652cbaa659b714766c5f5343308e7f0993cb4fb5581520c8745ca0275927" -> "ghcr.io/gsa-tts/fac/postgrest@sha256:fe10dfad7c13ee2a0828641ef7ab4544461d08681980112d147b8565c4377c78"
        id                              = "5de6f04c-52e0-400f-961a-16243b1c7c9a"
        name                            = "postgrest"
#        (17 unchanged attributes hidden)

#        (2 unchanged blocks hidden)
    }

  # module.dev.module.clamav.cloudfoundry_app.clamav_api will be updated in-place
!~  resource "cloudfoundry_app" "clamav_api" {
!~      docker_image                    = "ghcr.io/gsa-tts/fac/clamav@sha256:09e86b5cae004732505f7d3828e7121c54fd88572d72d929fec0f50bb5597d6e" -> "ghcr.io/gsa-tts/fac/clamav@sha256:49a1b0ba138e45f00d89001d8dd63733a4658bc43237e2ac378028bb37619dac"
        id                              = "779bbc51-f78a-4186-90eb-5acb68d7d746"
        name                            = "fac-av-dev"
#        (17 unchanged attributes hidden)

#        (1 unchanged block hidden)
    }

  # module.dev.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "*******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2025-01-30T20:42:20Z" -> (known after apply)
        }
    }

  # module.dev.module.file_scanner_clamav.cloudfoundry_app.clamav_api will be updated in-place
!~  resource "cloudfoundry_app" "clamav_api" {
!~      docker_image                    = "ghcr.io/gsa-tts/fac/clamav@sha256:09e86b5cae004732505f7d3828e7121c54fd88572d72d929fec0f50bb5597d6e" -> "ghcr.io/gsa-tts/fac/clamav@sha256:49a1b0ba138e45f00d89001d8dd63733a4658bc43237e2ac378028bb37619dac"
        id                              = "65c83416-4126-4785-99c2-5e1adb810422"
        name                            = "fac-av-dev-fs"
#        (17 unchanged attributes hidden)

#        (1 unchanged block hidden)
    }

Plan: 1 to add, 3 to change, 1 to destroy.

❌ Plan not applied in Deploy to Development and Management Environment #947 (Plan has changed)

[github-actions]

This pull request is not up to date with main. Please merge main into this brach or rebase this branch onto main. This PR should not be approved until all status checks pass. If you see this message, please rerun all status checks before merging.

[github-actions]

Package	Line Rate	Branch Rate	Health
.	100%	100%	✔
api	98%	90%	✔
audit	97%	87%	✔
audit.cross_validation	98%	88%	✔
audit.fixtures	84%	50%	❌
audit.intakelib	91%	82%	✔
audit.intakelib.checks	92%	85%	✔
audit.intakelib.common	98%	82%	✔
audit.intakelib.transforms	100%	95%	✔
audit.management.commands	78%	17%	❌
audit.migrations	100%	100%	✔
audit.models	94%	76%	✔
audit.templatetags	100%	100%	✔
audit.views	72%	54%	❌
census_historical_migration	96%	65%	✔
census_historical_migration.migrations	100%	100%	✔
census_historical_migration.sac_general_lib	92%	84%	✔
census_historical_migration.transforms	95%	90%	✔
census_historical_migration.workbooklib	68%	69%	❌
config	77%	37%	❌
curation	100%	100%	✔
curation.curationlib	93%	100%	✔
curation.migrations	100%	100%	✔
dissemination	91%	70%	✔
dissemination.migrations	97%	25%	✔
dissemination.searchlib	76%	66%	❌
dissemination.templatetags	100%	100%	✔
djangooidc	53%	38%	❌
djangooidc.tests	100%	94%	✔
report_submission	93%	88%	✔
report_submission.migrations	100%	100%	✔
report_submission.templatetags	74%	100%	❌
support	91%	66%	✔
support.migrations	100%	100%	✔
support.models	96%	50%	✔
tools	98%	50%	✔
users	95%	92%	✔
users.fixtures	100%	83%	✔
users.management	100%	100%	✔
users.management.commands	100%	100%	✔
users.migrations	100%	100%	✔
Summary	91% (18267 / 20043)	77% (2267 / 2952)	✔

Minimum allowed line rate is 85%