Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2025-01-31 | MAIN --> PROD | DEV (fc0fc8b) --> STAGING #4682

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Conversation

asteel-gsa
Copy link
Contributor

This is an auto-generated pull request to merge main into prod for a staging release on 2025-01-31 with the last commit being merged as fc0fc8b

jperson1 and others added 5 commits January 30, 2025 15:00
* Audit deletion workflow:

Rework "Audit submissions" page. Start button to top. Icons and copy.

"Submission checklist" page includes delete button and modal.

Circular icon component.

* Reformat home.html to four-space tabs

* Icons rework

New folder for FAC-specific icons.

Regenerate sprite.svg to include all usa, uswds, and fac icons.

* Remove the circular_icon component

Compound icons can be their own icon!

* Fromatting, remove unused JS

* Audit submissions page

Break modals into their own component files, update references

* Verify sac.general_information exists

Practically, it will always exist. But we don't want to have to set the value for every possible test.

* Audit submissions and Cypress

Always display helper text

Initialize audit with new workflow

Minor fixes

* Audit deletion final design

EOF newlines

Move deletion modal up a level, use it in the checklist

* Allow audit deletion in certifying states

These are also in progress, from the POV of the user.

* Linting!

Sometimes we forget things and push them too early.

* Submission checklist title, tabs to spaces

* Componentization - fun word?

Break audit_submissions tables into components

Rename components to include their type first, name second

* Djlint configuration

Create rule C001 - use spaces, not tabs. Resolve the rule breaking.

Include rule H035 - self close meta tags

* Deletion changes

Remove deletion modal from accepted submissions, rename component

* Admin tests - docstings for audit deletion/revert

* Remove submission view updates

Allow removal of certified reports

Add permission protection on the POST, just in case

Basic test cases to verify functionality in several statuses

* Audit deletion workflow minor small screen changes

* Sometimes, we commit a test word or two. Woops.

* Fix import of renamed component.
* Update FederalProgramNames.json

* Add files via upload

* Update README.md

* Updating workbook schemas to 1.1.4

* Update backend/schemas/README.md

Co-authored-by: Dan Swick <[email protected]>

* Update backend/schemas/README.md

Co-authored-by: Dan Swick <[email protected]>

* Update Makefile

Makefile will now merge the 2 CSV and update FederalProgramNames.json

* Update generate_lookup_schemas.py

* Create merge-csv-alns.py

* Update Makefile

Runs merge-csv-alns.py

* Create ReadMe

* Add files via upload

* Fixing merge command

* Removing dates from aln csvs

* Lint

* Update README.md

* Adding OS check to Makefile

* Updating README

* Fixing version enums

* Removing extra csv

* Merge script now skips bad ALNs

* Lint

* Fixing version enums

* Updating README

* Fixing version enums

* Update merge_aln_csvs.py

Sorting by ALN and removing unnecessary columns of data from final merged file

* Fixes for column renaming

* No longer validating numbers

* Updating cypress wb fixtures

---------

Co-authored-by: Philip Dominguez <[email protected]>
Co-authored-by: Dan Swick <[email protected]>
* Revert node 23 to node 20

* Dockerfile Node 23 to 20
* Updatd search alert and screen in line with
designs

* updated search headings

* Updated test and applied formatting to div

* Ran black to format

* Formatted p tags

* Changed text color for accessability

* Added rel reference to _blank target
@asteel-gsa asteel-gsa added autogenerated Automated pull request creation automerge Used for automated deployments labels Jan 31, 2025
Copy link
Contributor

github-actions bot commented Jan 31, 2025

Terraform plan for staging

Plan: 1 to add, 0 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.staging.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "*******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2025-01-30T10:53:43Z" -> (known after apply)
        }
    }

Plan: 1 to add, 0 to change, 1 to destroy.

✅ Plan applied in Deploy to Staging Environment #327

Copy link
Contributor

Terraform plan for production

Plan: 1 to add, 0 to change, 1 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
-/+ destroy and then create replacement

Terraform will perform the following actions:

  # module.production.module.cors.null_resource.cors_header must be replaced
-/+ resource "null_resource" "cors_header" {
!~      id       = "******************" -> (known after apply)
!~      triggers = { # forces replacement
!~          "always_run" = "2025-01-29T18:13:51Z" -> (known after apply)
        }
    }

Plan: 1 to add, 0 to change, 1 to destroy.

📝 Plan generated in Pull Request Checks #4330

Copy link
Contributor

Code Coverage

Package Line Rate Branch Rate Health
. 100% 100%
api 98% 90%
audit 97% 87%
audit.cross_validation 98% 88%
audit.fixtures 84% 50%
audit.intakelib 91% 82%
audit.intakelib.checks 92% 85%
audit.intakelib.common 98% 82%
audit.intakelib.transforms 100% 95%
audit.management.commands 78% 17%
audit.migrations 100% 100%
audit.models 94% 76%
audit.templatetags 100% 100%
audit.views 72% 54%
census_historical_migration 96% 65%
census_historical_migration.migrations 100% 100%
census_historical_migration.sac_general_lib 92% 84%
census_historical_migration.transforms 95% 90%
census_historical_migration.workbooklib 68% 69%
config 77% 37%
curation 100% 100%
curation.curationlib 93% 100%
curation.migrations 100% 100%
dissemination 91% 70%
dissemination.migrations 97% 25%
dissemination.searchlib 76% 66%
dissemination.templatetags 100% 100%
djangooidc 53% 38%
djangooidc.tests 100% 94%
report_submission 93% 88%
report_submission.migrations 100% 100%
report_submission.templatetags 74% 100%
support 91% 66%
support.migrations 100% 100%
support.models 96% 50%
tools 98% 50%
users 95% 92%
users.fixtures 100% 83%
users.management 100% 100%
users.management.commands 100% 100%
users.migrations 100% 100%
Summary 91% (18265 / 20041) 77% (2267 / 2952)

Minimum allowed line rate is 85%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autogenerated Automated pull request creation automerge Used for automated deployments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants