[DRAFT] End-to-end test service starting point #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now to integrate...
This lets fetch/walk/etc. hit the internal e2e container.
jadudm
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // If we are running against a fake domain, and in our local stack, | ||
| // we want this to pass. This will only work in the containerized env. | ||
| if env.IsContainerEnv() { | ||
| except, _ := regexp.MatchString(`^http://www.e2e.gov`, u.String()) |
Check failure
Code scanning / CodeQL
Incomplete regular expression for hostnames High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 2 days ago
To fix the problem, we need to escape the dot in the regular expression to ensure it matches only a literal dot and not any character. This can be done by replacing . with \\. in the regular expression. Additionally, using a raw string literal can make the regular expression more readable and avoid the need to escape backslashes.
Suggested changeset
1
internal/filtering/general.go
| @@ -59,3 +59,3 @@ | ||
| if env.IsContainerEnv() { | ||
| except, _ := regexp.MatchString(`^http://www.e2e.gov`, u.String()) | ||
| except, _ := regexp.MatchString(`^http://www\.e2e\.gov`, u.String()) | ||
| if except { |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR could be kept a draft, or we could decide we want to bring the code in and iterate.
Unit tests are important in many ways, but I'd trade code coverage on things that don't matter for good end-to-end tests every day of the week. Put another way: I think unit tests matter on core operations: algorithmic transforms, logic, storage operations, etc., but there are other places where an end-to-end test, demonstrating the application logic, matter more to me (personally).
My personal vision (to be discussed) is that we have a way of running end-to-end tests on a daily basis. I would like to see:
This
e2eservice may, or may not, be part of that. It provides a small service that serves static webpages. I pulled one page from NASA, and one from the FAC. Over time, we might pull more. I also excepted the domaine2e.gov(which perhaps should change) from various rules, so that we can set up a fake domain resolution and crawl this as if it were any other site (including locally). This way, we can run the tests in the local docker stack.More thought will need to be given, however. Ideally, we would run against a
stagingdeployment. This would serve for that, too, but may require more thought/development.As stated... perhaps we keep this in draft, or perhaps we pull this in to the stack and play with it further.