restore international numbers #1629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 3, 2025 08:02
ccostino
reviewed
Apr 7, 2025
There was a problem hiding this comment.
Thank you, @terrazoon!
All looks good to me here as far as the changes go, I just had a couple of questions where you had a questions noted to see if we can sort them out before merging.
xlorepdarkhelm
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We originally removed the capability to send to international numbers because they were not part of any immediate use case we were going to support.
Restore this ability by removing the way we blocked it (checking for +1), and restore the existing tests for international numbers.
Note: This is 99% successful but there were two anomalies to note: For the Cook Islands and for Egypt, we get some kind of formatting failure. I don't think this will prevent sending, only mess up the preview. Unfortunately we don't have any Cook Island or Egypt numbers to test with.
Also, AWS provides some simulated international numbers. I ran through these and 22 out of 24 passed. We had one failure where we never got an answer back from Norway -- I assume because the AWS simulated number is broken in some way. Also, the UK simulated number failed with "no origination authority", which sounds more serious and legit, so something to investigate at some point.
Security Considerations
N/A