과제 1-1 jihoonwjj 과제제출 #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowykte0426
requested changes
Feb 21, 2025
| } | ||
|
|
||
| @PatchMapping(("/{id}")) | ||
| public ResponseEntity<Ang> editThatShit(AnggimoddiDTO anggimoddiDTO, @PathVariable Long id) { |
There was a problem hiding this comment.
@Vaild 어노테이션 적용 안하면 값 검증이 활성화가 안되요!
Comment on lines
+8
to
+16
| @NoArgsConstructor | ||
| @AllArgsConstructor | ||
| @Getter | ||
| @Builder | ||
| public class AnggimoddiDTO { | ||
| private Long id; | ||
| private String title; | ||
| private String content; | ||
| } |
There was a problem hiding this comment.
@Size나 @Max 등 수많은 값 검증 어노테이션이 있으니까 특히 Request로 받는 DTO는 검증을 강화해줍시다
Comment on lines
+17
to
+24
| public ResponseEntity<List<Ang>> getAngs() { | ||
| try { | ||
| return ResponseEntity.ok(angRepository.findAll()); | ||
| } catch (IllegalArgumentException e) { | ||
| List<Ang> emptyList = Collections.emptyList(); | ||
| return ResponseEntity.ok(emptyList); | ||
| } | ||
| } |
There was a problem hiding this comment.
같이 협업하는 클라이언트 마다 다르긴 했는데 대부분의 클라이언트는 List형 API에서는 값이 없으면 그냥 Empty List를 반환해 주는 것을 선호하더라고요
Comment on lines
+11
to
+22
| @NoArgsConstructor(access = AccessLevel.PROTECTED) | ||
| public class Ang extends BaseIdxEntity{ | ||
| private String title; | ||
| private String content; | ||
|
|
||
| @Builder | ||
| public Ang(Long idx, String title, String content){ | ||
| this.idx = idx; | ||
| this.title = title; | ||
| this.content = content; | ||
| } | ||
| } |
| private final AngRepository angRepository; | ||
|
|
||
| public ResponseEntity<Ang> postPost(Ang ang) { | ||
| return ResponseEntity.ok(angRepository.save(ang)); |
There was a problem hiding this comment.
이런 식으로 설계되어 있으면 오류 발생 시 500뜨고 말거나 이상한 값이 날라갈 거 같은데 예외 처리를 해주는건 어떨까요
| import org.springframework.http.ResponseEntity; | ||
| import org.springframework.stereotype.Service; | ||
|
|
||
| @Service |
There was a problem hiding this comment.
이 녀석 인터페이스에 @Service? 보통의 Aura가 아니군
Comment on lines
+26
to
+39
| @GetMapping("/") | ||
| public ResponseEntity<List<Ang>> getShitAll() { | ||
| return getPost.getAngs(); | ||
| } | ||
|
|
||
| @GetMapping("/{id}") | ||
| public ResponseEntity<Optional<Ang>> getThatShit(@PathVariable Long id) { | ||
| return getPost.getAngById(id); | ||
| } | ||
|
|
||
| @PostMapping("/") | ||
| public ResponseEntity<Ang> makeShit(Ang ang) { | ||
| return postpost.postPost(ang); | ||
| } |
There was a problem hiding this comment.
GET /articles나 POST /articles 와 같은 상황에서는 ("/")로 명시하는 것보다 그냥 아무것도 안남기고 @PostMapping 이렇게만 하는게 관례에 더 맞을 것 같습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.