🔀출석 기능 추가 #296

happytaeyoon · 2024-04-24T22:57:45Z

💡 개요

출석 기능을 추가했습니다

📃 작업내용

AttendPage를 만들었습니다

🎸 기타

테스트 많이 해주시면 좋을 것 같아요!

vercel · 2024-04-24T22:57:51Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
gcms-msg-team	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 24, 2024 11:32pm

likegitman

커밋 컨벤션 지켜주세요!

mini-aron · 2024-04-24T23:54:46Z

components/AttendPage/AttendanceForm.tsx

+                  ? '10교시'
+                  : period === 'ELEVENTH'
+                  ? '11교시'
+                  : ''


삼항연산자가 아니라 periodArr를 통해서 관리하는 건 어떨까요?

mini-aron · 2024-04-25T00:03:18Z

type/store/applicant.ts

@@ -1,4 +1,5 @@
 export interface ApplicantInitialState {
+  attendanceId?: any


attendanceId를 any로 설정한 이유가 있나요?

mini-aron · 2024-04-25T00:10:22Z

assets/svg/Attend_LATE.tsx

@@ -0,0 +1,17 @@
+export const Attend_LATE = ({ color }: { color?: string }) => {


svg 컴포넌트들의 color의 타입을 boolean으로 변경하거나, color에 string값으로 색상정보를 가져오는방식으로 변경하는 것이 좋아보여요

likegitman

커밋 컨벤션 지켜주세요!

likegitman · 2024-04-24T23:35:49Z

assets/svg/Attend_ABSENT.tsx

@@ -0,0 +1,26 @@
+export const Attend_ABSENT = ({ color }: { color?: string }) => {


Attend_ABSENT를 비롯한 3개 svg의 이름을 스네이크케이스로 작성한 이유가 있을까요?

likegitman · 2024-04-24T23:37:38Z

components/AttendPage/AttendanceForm.tsx

+  create,
+  download,
+}) => {
+  const yoilArr = ['일', '월', '화', '수', '목', '금', '토']


한글로 요일은 yoil로 하는 것보다 weeks같은 네이밍은 어떤가요?
그리고 변하지 않는 변수는 AttendanceForm 밖에 선언하는 것이 더 좋을 것 같습니다.

likegitman · 2024-04-24T23:40:52Z

components/AttendPage/AttendanceForm.tsx

+                period === 'FIRST'
+                  ? '1교시'
+                  : period === 'SECOND'
+                  ? '2교시'
+                  : period === 'THIRD'
+                  ? '3교시'
+                  : period === 'FOURTH'
+                  ? '4교시'
+                  : period === 'FIFTH'
+                  ? '5교시'
+                  : period === 'SIXTH'
+                  ? '6교시'
+                  : period === 'SEVENTH'
+                  ? '7교시'
+                  : period === 'EIGHTH'
+                  ? '8교시'
+                  : period === 'NINTH'
+                  ? '9교시'
+                  : period === 'TENTH'
+                  ? '10교시'
+                  : period === 'ELEVENTH'
+                  ? '11교시'
+                  : ''


이런 중복된 삼항 연산자는 좋지 않은 것 같아요!
따로 객체를 만들어서 key들을 FIRST, SECOND 등으로 하고 해당하는 value들을 교시로 지정해놔서
obj[period] 식으로 줄여보는 건 어떨까요?

likegitman · 2024-04-24T23:45:08Z

type/store/applicant.ts

@@ -1,4 +1,5 @@
 export interface ApplicantInitialState {
+  attendanceId?: any


any로 지정하신 이유가 있나요?

likegitman · 2024-04-24T23:46:38Z

components/AttendPage/AttendanceForm.tsx

+interface AttendanceFormProps {
+  onClose: () => void
+  isShow: string
+  setIsPick: React.Dispatch<React.SetStateAction<string>>
+  setClicked: React.Dispatch<React.SetStateAction<boolean>>
+  date: Date
+  setDate: React.Dispatch<React.SetStateAction<Date>>
+  setCurrentDate: React.Dispatch<React.SetStateAction<string>>
+  clicked: boolean
+  selectedPeriods: PeriodEnumType[]
+  isPick: string
+  onClickPeriod: (period: PeriodEnumType) => void
+  periodArr: { text: string; period: PeriodEnumType }[]
+  create: () => void
+  download: () => void
+}


is가 네이밍은 boolean 형태에 적합하다 생각하는데 바꿔보는 걸 추천드리고 isPick은 타입이
'calendar와 period로 정확히 나뉘어져 있는 것 같은데 string 말고 직접 지정하는 게 좋을 것 같습니다.

likegitman · 2024-04-25T00:13:48Z

components/AttendPage/index.tsx

+                onClick={() => {
+                  setIsShow('조회하기')
+                }}
+                style={{ cursor: 'pointer' }}


NavWrapper에 cursor: pointer를 주지 않고 직접 인라인으로 스타일 주신 이유가 있나요?

likegitman · 2024-04-25T00:14:01Z

components/AttendPage/index.tsx

+                onClick={() => {
+                  setIsShow('생성하기')
+                }}
+                style={{ cursor: 'pointer' }}


위 코멘트와 같습니다.

likegitman · 2024-04-25T00:14:52Z

components/AttendPage/index.tsx

+          )}
+
+          <UserList data={attendData} value={watch('value').trim()} />
+          <ChoiceUser onSubmit={() => attendanceDownload()} />


따로 받는 인자가 없다면 onSubmit={attendanceDownload}로 줄여도 문제가 생길 것 같지 않은데 어떤가요?

likegitman · 2024-04-25T00:15:31Z

components/AttendPage/index.tsx

+            <Input placeholder='검색' register={register('value')} />
+          </S.InputBox>
+
+          {attendData && attendData.users.length > 0 && (


0보다 크다라는 조건은 attendData.users.length랑 똑같은 의미일 것 같은데 바꾸실 의향이 있나요?

likegitman · 2024-04-25T00:16:04Z

components/AttendPage/style.ts

+  > svg {
+    position: absolute;
+    left: 20px;
+    bottom: 16px;
+  }
+  input {
+    padding: 0.9rem 3rem;
+  }


svg에만 >를 붙인 이유가 있나요?

likegitman · 2024-04-25T00:19:59Z

components/Common/ClubNav/index.tsx

router.push를 사용하지 않고 href를 이용하신 이유가 있나요?

happytaeyoon added 2 commits April 25, 2024 01:17

add AttendPage

f4119ef

add removeAllUser

8fb6144

happytaeyoon added 1️⃣ Priority: High 우선순위 - 상 ✨ Feature 신규 기능 labels Apr 24, 2024

happytaeyoon self-assigned this Apr 24, 2024

happytaeyoon requested review from likegitman, mini-aron and ws-071211 as code owners April 24, 2024 22:57

fix svg CamelCase

bc1b240

vercel bot had a problem deploying to Preview April 24, 2024 23:06 Failure

fix build error

96a256a

vercel bot deployed to Preview April 24, 2024 23:32 View deployment

likegitman reviewed Apr 24, 2024

View reviewed changes

mini-aron reviewed Apr 25, 2024

View reviewed changes

likegitman reviewed Apr 25, 2024

View reviewed changes

components/Common/ClubNav/index.tsx

Copy link

Contributor

likegitman Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

router.push를 사용하지 않고 href를 이용하신 이유가 있나요?

ws-071211 approved these changes Apr 25, 2024

View reviewed changes

happytaeyoon merged commit e9459a7 into develop Apr 25, 2024
3 checks passed

likegitman mentioned this pull request Apr 25, 2024

🔀 Deploy #297

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🔀출석 기능 추가 #296

🔀출석 기능 추가 #296

happytaeyoon commented Apr 24, 2024

vercel bot commented Apr 24, 2024 •

edited

Loading

likegitman left a comment

mini-aron Apr 24, 2024

mini-aron Apr 25, 2024

mini-aron Apr 25, 2024

likegitman left a comment

likegitman Apr 24, 2024

likegitman Apr 24, 2024

likegitman Apr 24, 2024

likegitman Apr 24, 2024

likegitman Apr 24, 2024

likegitman Apr 25, 2024

likegitman Apr 25, 2024

likegitman Apr 25, 2024

likegitman Apr 25, 2024

likegitman Apr 25, 2024

likegitman Apr 25, 2024

		@@ -1,4 +1,5 @@
		export interface ApplicantInitialState {
		attendanceId?: any

		@@ -0,0 +1,17 @@
		export const Attend_LATE = ({ color }: { color?: string }) => {

		@@ -0,0 +1,26 @@
		export const Attend_ABSENT = ({ color }: { color?: string }) => {

🔀출석 기능 추가 #296

🔀출석 기능 추가 #296

Conversation

happytaeyoon commented Apr 24, 2024

💡 개요

📃 작업내용

🎸 기타

vercel bot commented Apr 24, 2024 • edited Loading

likegitman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

likegitman left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vercel bot commented Apr 24, 2024 •

edited

Loading