Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Mixin-related Fixes #890

Merged
merged 13 commits into from
Mar 9, 2025
Merged

Various Mixin-related Fixes #890

merged 13 commits into from
Mar 9, 2025

Conversation

glowredman
Copy link
Member

This PR includes:

  • General cleanup
    • Update deps
    • Remove dead code
    • Add missing @Override annotations
    • Fix generics
    • Add serialVersionUIDs
    • Address deprecation warnings
    • Use @WrapWithCondition v2 instead of the deprecated v1
    • Replace static method access using objects with static method access using types
  • Use AccessTransformers instead of mixins (I know some don't like them but they make the code more readable, don't add new instructions and don't create conflicts with other mixins doing the same thing)
  • Fix two conflicts with ArchaicFix
  • Add @Mutable annotations to @Final fields that are modified
  • Fix two injection targets (one incorrectly specified remap = false, the other can be solved without having to shift by 2)

@glowredman glowredman requested review from mitchej123 and a team March 3, 2025 17:56
@Dream-Master Dream-Master requested a review from a team March 3, 2025 19:28
@mitchej123 mitchej123 merged commit bb55265 into master Mar 9, 2025
1 check passed
@mitchej123 mitchej123 deleted the fix-mixins branch March 9, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants