Fix stencil buffer does not exist #912
Merged
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes FBO is provided without stencil buffer when Angelica is loaded and StencilBits parameter is enabled on Forge
MixinFlameBuffer mixins frame buffer class, creates its own FBO with its own depth buffer.
However, it does not consider stencil buffer is also created in the targeted function if the configuration is enabled, so the Minecraft standard FBO will always be delivered without the stencil buffer.
(Gl11.glGetInteger(GL_STENCIL_BITS) is always zero)
I found some mods uses stencil buffer to scissor the edge of scroll bars on vanilla FBO, so I think this should be fixed
Bugged scroll bar from ModularUI:
8mb.video-U2Q-9xeVhgWG.mp4