Added Saveable Schematics for the Ring of Loki #75
Conversation
There was a problem hiding this comment.
I can't say much about how well ModularUI is used here, however I have a few points:
- If you want to use ModularUI: make this feature optional. At the moment, ModularUI is introduced as a hard-dep (and not even declared as one). Botania is listed as active support, so introducing new deps must have a good reason. A cleaner solution (although quite some work) would be reimplementing the GUI without ModularUI.
- The textures are to high-res. The files are way to big and the textures don't fit in with MC's style and are to detailed for the size they are displayed at.
|
Reimplementing GUI with vanilla is quite painful and kills the point in using library. Making it no-op when MUI is missing would be good. |
|
The UI has been migrated to MUI2, the icons have been swapped for 16x16 icons, and I added method stripping and conditional checks to make sure that MUI is loaded for anything relating to the management UI. |
| public static String getLokiCearText(ItemStack stack){ | ||
| public static String getLokiClearText(){ |
There was a problem hiding this comment.
Please don't rename public fields/methods. Other mods may depend on this.
There was a problem hiding this comment.
There weren't any uses that I could find within the GTNewHorizons org, but if you want me to change it back I can.
https://github.com/search?q=org%3AGTNewHorizons+getLokiCearText&type=code
There was a problem hiding this comment.
This was added by Lewis ~2 years ago, so it's unlikely that anyone is using it outside of NH.
But in general, 100% - don't remove/rename/adjust parameters on public methods
glowredman
dismissed
their stale review
Changes requested were made, can't say much about the GUI code.
This PR adds saveable schematics for the Ring of Loki, adding keybinds to:
The schematic management UI is the UI you will use to manage your schematics (as the name implies), allowing you to select the schematic you want to use, change the names of schematics, and delete existing schematics.
Other than that, it's a fairly straightforward change, and doesn't add any real functionality to loki, just some QoL that makes loki a bit easier to use.
Demo
Quick note: I am NOT attached to the icons or background that are included in this PR, and if anyone has alternatives they'd like to create/offer, I'm 100% on board with anything that you think may fit the aesthetic of Botania more, these were some I just pulled together in like 5 minutes.
It also should be noted this was my first time ever making a UI with any UI framework, not just MUI, so this UI code is probably absolutely terrible and if anyone smarter than I has comments, feel free to rip it apart.