-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GT++ ASM Cleanup #3238
Merged
Merged
GT++ ASM Cleanup #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexdoru
added
enhancement
Improve an existing mechanic. Please explain the change with a before/after comparison.
bug fix
Fix a bug. Please link it in the PR.
refactor
For PRs rewritting a part of the code to have a nicer code overall.
labels
Sep 21, 2024
… respected anyway because of a bug with mixins
…lready one in the targeted code...
Alexdoru
force-pushed
the
asm-rework
branch
from
September 21, 2024 12:27
9df810c
to
6331449
Compare
mitchej123
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug fix
Fix a bug. Please link it in the PR.
enhancement
Improve an existing mechanic. Please explain the change with a before/after comparison.
refactor
For PRs rewritting a part of the code to have a nicer code overall.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit history
Deleting the ASM keyboard out of bound fix because :
I also delete the ItemWispEssence asm fix and moved it to hodgepodge
Delete the cofh ore dict asm and move it the a mixin in hodgepodge
Delete the forge ore dict asm since it injects a null check that already exists in the base code
See GTNewHorizons/Hodgepodge#423