Clean up some deprecation usages #3698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove usages of deprecated stopMachine() - Switch to checkProcessing() from checkMachine() - Delete unused method onRunningTickTabbedMode()
- Move away from deprecated stopMachine() override - Remove deprecated onWireCutterRightClick() usage - Cleanup spawnVisualPistonBlocks() and getAllBlockTiers() warnings
- Remove deprecated stopMachine() usage - Remove unnecessary cast - Remove 2 identical overrides
- remove usage of deprecated stopMachine()
- Use checkProcessing() over checkRecipe() - Fix cast warning
serenibyss
requested review from
mitchej123 and
a team
and removed request for
mitchej123
serenibyss
added
the
refactor
- Use checkProcessing() over checkRecipe() - Move away from deprecated stopMachine()
- Use checkProcessing() over checkRecipe() - Remove deprecated stopMachine() override
- Use checkProcessing() over checkRecipe()
- move away from deprecated onWireCutterRightClick() and onSolderingToolRightClick()
- move away from deprecated onSolderingToolRightClick()
- move away from deprecated onWrenchRightClick()
- move away from deprecated onWireCutterRightClick()
- move away from deprecated onWireCutterRightClick() - remove 3 methods identical to super - remove unused addToFRFList()
- move away from deprecated onWireCutterRightClick()
- move away from deprecated onWireCutterRightClick() - move away from deprecated survivalConstruct()
HoleFish
reviewed
Dec 25, 2024
src/main/java/bartworks/common/tileentities/multis/MTEHighTempGasCooledReactor.java
Outdated
Show resolved
Hide resolved
src/main/java/bartworks/common/tileentities/multis/MTEHighTempGasCooledReactor.java
Outdated
Show resolved
Hide resolved
StaffiX
approved these changes
Jan 4, 2025
Dream-Master
removed
the
🚧 Testing on Zeta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a lot of usage/overrides of deprecated methods, primarily
checkMachine(ItemStack),stopMachine(), andcriticalStopMachine()Commit descriptions go into more detail for each machine, though it should be relatively straightforward