Don't ignore Tinker's Construct blocks in ore registration. #3709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This lets them work with the Type Filter machines, and it shouldn't cause unwanted unification or recipe creation.
|
for the gravel ore: doesnt this create duplicate recipes? and different ones most likely as the current ones dont have byproducts? (looking at iron as an example right now) |
chochem
requested changes
Jan 3, 2025
Dream-Master
removed
the
🚧 Testing on Zeta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets them work with the Type Filter machines, and it shouldn't cause unwanted unification.
Incidentally this also works for the various gravel ores which would also get picked up by the type filter. This would be appropriate since they have the same macerator recipes as their regular ore counterparts.
The only side effect I noticed in the full pack is one additional duplicated compressor recipe for metal blocks of TiCo types like Cobalt, so they have 3 copies of the exact same recipe instead of 2. I'm given to understand this problem is to be handled by switching Materials system altogether and so it would be safe to ignore for the context of this PR.
Would fix GTNewHorizons/GT-New-Horizons-Modpack#15990