Add NC hatches for PCB Factory and QFT #3737
Merged
+944
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GDCloudstrike
added
enhancement
Dream-Master
added
the
🚧 Testing on Zeta
|
Should mention them in QFT's and PCB's tooltip |
# Conflicts: # src/main/java/gregtech/api/enums/ItemList.java
|
Warning: 2 uncommitted changes |
serenibyss
reviewed
Jan 10, 2025
src/main/java/gregtech/loaders/postload/chains/PCBFactoryRecipesNoNanites.java
Outdated
Show resolved
Hide resolved
src/main/java/gtPlusPlus/xmod/gregtech/loaders/recipe/RecipeLoaderQFTNoCatalysts.java
Outdated
Show resolved
Hide resolved
serenibyss
approved these changes
Jan 12, 2025
Dream-Master
removed
the
🚧 Testing on Zeta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds hatches that are designed to hold mass amounts of nonconsumable items for use in multiblocks. They act identically to super chests and have filtering for items they are allowed to use for their purpose (e.g. Nanite Bus only allows insertion of nanites). The UI also features a new button for locking the output slot, enabled by default (to not lose out on the first inserted stack).
The main reason for the addition of these hatches is to eliminate the stocking bus exploit that allowed an infinite amount of nonconsumables to be used in recipes even with only a single item (because of multiple storage buses reporting multiples of the real item).
This PR adds two of these hatches, the Nanite Containment Bus and the Bulk Catalyst Housing, for use in the PCB factory and QFT respectively. These can be reused in other multiblocks too if needed, and new ones can be added with relative ease.
The processing logic of the PCB factory and QFT has also been adjusted to check for the nonconsumables in the hatches directly, instead of searching in regular input buses (meaning cribs wont break).
Recipes will follow in a coremod PR.