Make BlockPos modifications return BlockPos instead of IBlockPos #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the return type of methods in BlockPos, but not changing the IBlockPos interface.
Idk if it ABI compat, but it does API compat.
This fixes the problem that you'll need to cast the return values to BlockPos, when you maintaining a Collection of BlockPos.
In newer forges/fabrics (e.g.: 1.12.2), there isn't a IBlockPos interface, so all methods return BlockPos. It is misleading.
And one more reason is that, BlockPos is mutable, so at least the return types should be
IMutableBlockPosinstead ofIBlockPos, because it loses the set methods.