Fix Witchery's Mirror Reflections #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow getDownloadImageSkin() fixes (such as GTNewHorizons#237) to apply to Witchery's Mirror content (demon reflections, player camouflage and sleeping bodies). This wasn't fixed before due to Witchery's decision to copy and paste that vanilla class rather than reference it.
DrParadox7
force-pushed
the
WitcheryFix
branch
from
e9b6c64 to
1a636da
Compare
mitchej123
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
getDownloadImageSkin()fixes to apply to Witchery's Mirror content (demon reflections, player camouflage and sleeping bodies).See issue in GTNewHorizons/GT-New-Horizons-Modpack#13903
This wasn't fixed before by solutions such as #237 primarily due to Witchery's decision to duplicate the vanilla method rather than referencing it.