-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modded Block/Item/Entity Stats #398
Conversation
How are you handling if a mod manually adds their items to the stat list? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was not tested in full pack; needs error handling
@Caedis Item/Block stats are registered during |
If no one approve this very soon I will merge it. It’s on zeta for a while and I get no negative feedback. |
@Caedis it is on zeta formore than 4 weeks. So it is tested in full pack |
Block/Items stats are registered by injecting in the GameRegistry methods which register them. Entity stats are registered when the server started. The stat arrays for blocks/items are remapped when the block/item ids change.
Note: block/item stats may not work depending on how the mods override certain functions. This affects craft stats the most.
Other changes:
@WrapWithCondition
v2