Limit recursive block updates to prevent stack overflow crashes #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alexdoru
requested changes
Sep 21, 2024
.../com/mitchej123/hodgepodge/mixins/early/minecraft/MixinWorldServer_LimitUpdateRecursion.java
Outdated
Show resolved
Hide resolved
.../com/mitchej123/hodgepodge/mixins/early/minecraft/MixinWorldServer_LimitUpdateRecursion.java
Outdated
Show resolved
Hide resolved
.../com/mitchej123/hodgepodge/mixins/early/minecraft/MixinWorldServer_LimitUpdateRecursion.java
Outdated
Show resolved
Hide resolved
Alexdoru
requested changes
Sep 21, 2024
There was a problem hiding this comment.
If I understand your mixin correctly, it's going to increment the hodgepodge$currentBlockUpdateRecursiveCalls counter every time there is a block update on the server - for any block - and once it reaches 256 it will cancel all the block updates - for any block- that's just breaking the behavior of the minecraft server
Alexdoru
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some configurations of water and lava can cause infinite recursive block update loops (this seems to be a vanilla bug), this is not a full fix but it at least stops crashes from happening and replaces them with logging.
Tested by setting the limit to a very low value in dev and observing suppressed block updates during worldgen.