client, server: record basic telemetry events #143
+209
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first attempt tried to overload a method that doesn't exist in the pinned version of our `linol` dependency.
samcowger
force-pushed
the
sc/cn-lsp-telemetry
branch
from
52441a6 to
e8233fc
Compare
samcowger
force-pushed
the
sc/cn-lsp-telemetry
branch
from
e8233fc to
15123dd
Compare
samcowger
added a commit
that referenced
this pull request
Jan 22, 2025
I've run into trouble with multiple configurations in #143, since that introduces dependencies between these local packages. This approach seems to solve those problems, and I think it's somewhat more idiomatic anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In furtherance of #125, this implements generation and serialization of timestamped telemetry events for several key points in the server/verification lifecycle, mentioned in that issue:
It also updates the client to allow a user to choose whether to collect and where to store telemetry. This collection is disabled by default.
This leaves some aspects of #125 unimplemented:
There are no technical blockers to implementing (1) and (2), and they're next on my list. I think there are also no technical blockers for (3), but I don't yet know how, abstractly, we want to define a task. (@kschleisman, I'm hoping we can cover this when you're in town next week.)