Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvements from workshop #625

Merged
merged 3 commits into from
Nov 29, 2023
Merged

improvements from workshop #625

merged 3 commits into from
Nov 29, 2023

Conversation

capital-G
Copy link
Member

Some small improvements derived from the workshop.

The connection problems within the MIT network most likely derive from encapsulating the sound container within a docker network/NAT (see 277c911 ), so lets get rid of this again.

I will try to check out this on the dev server before merging it to verify that it is in a state how it should be.

@capital-G capital-G requested a review from vin-ni November 27, 2023 11:50
Copy link

github-actions bot commented Nov 27, 2023

File Coverage
All files 82%
gencaster/db_logging.py 96%
gencaster/distributor.py 68%
gencaster/schema.py 55%
gencaster/urls.py 76%
osc_server/models.py 91%
osc_server/server.py 55%
story_graph/engine.py 84%
story_graph/markdown_parser.py 91%
story_graph/models.py 97%
story_graph/types.py 93%
stream/frontend_types.py 94%
stream/models.py 92%
stream/types.py 99%

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against 4d4f031

Copy link
Member

@vin-ni vin-ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@capital-G capital-G merged commit 539f313 into main Nov 29, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants