Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tutorial #634

Merged
merged 2 commits into from
Dec 5, 2023
Merged

add tutorial #634

merged 2 commits into from
Dec 5, 2023

Conversation

capital-G
Copy link
Member

wrote a small tutorial for the beta test.

@capital-G capital-G requested a review from vin-ni December 5, 2023 00:03
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023 •
edited
Loading

File Coverage
All files 82% ✅
gencaster/db_logging.py 96% ✅
gencaster/distributor.py 68% ✅
gencaster/schema.py 55% ✅
gencaster/urls.py 76% ✅
osc_server/models.py 91% ✅
osc_server/server.py 55% ✅
story_graph/engine.py 84% ✅
story_graph/markdown_parser.py 91% ✅
story_graph/models.py 97% ✅
story_graph/types.py 93% ✅
stream/frontend_types.py 94% ✅
stream/models.py 92% ✅
stream/types.py 99% ✅

Minimum allowed coverage is 50%

Generated by 🐒 cobertura-action against 1f1eebf

@capital-G capital-G mentioned this pull request Dec 5, 2023
Open
9 tasks
@capital-G
Copy link
Member Author

Style of the tutorial goes like this

image

Also improved some other sections within the docs

image

vin-ni
vin-ni requested changes Dec 5, 2023
View reviewed changes
Copy link
Member

@vin-ni vin-ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is absolutely fantastic!
Thank you!

@capital-G
Copy link
Member Author

@vin-ni I adjusted the things you suggested - is it OK to merge now b/c the PR is on "change requested"

@vin-ni vin-ni self-requested a review December 5, 2023 20:01
vin-ni
vin-ni approved these changes Dec 5, 2023
View reviewed changes
Copy link
Member

@vin-ni vin-ni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved <3

@capital-G capital-G merged commit 50759f7 into main Dec 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vin-ni vin-ni vin-ni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@capital-G @vin-ni