wasmfx #76
Merged
wasmfx #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuoguo
reviewed
Dec 12, 2024
| // FIXME: handlers are lost here | ||
| kont(s ++ restStack, List(), s1 => k1(s1, List(), m1)) // mkont lost here | ||
| val index = trail.indexWhere { case (_, tags) => tags.contains(tagId) } |
There was a problem hiding this comment.
How do you guarantee you always find the first handler of tag_id
ahuoguo
reviewed
Dec 12, 2024
| } | ||
| val newStack = ContV(kr) :: inputs | ||
| hs.find(_._1 == tagId) match { | ||
| case Some((_, handler)) => handler(newStack, initK[Ans], List(), mkont) | ||
| case Some((_, handler)) => |
There was a problem hiding this comment.
ideally hs.find(_._1 == tagId) and tags.contains(tagId) find the same resume clause
|
I think this implementation is pretty mature. There's one more thing I want to test. make nested_resume a bit more nested to test whether we are handling Then, we can maybe get rid of meta-continuations for wasmfx |
ahuoguo
reviewed
Dec 14, 2024
src/main/scala/wasm/MiniWasmFX.scala
Outdated
| val kr = (s: Stack, _: Cont[Ans], t1: Trail[Ans], m1: MCont[Ans], hs1: Handlers[Ans]) => { | ||
| val index = trail.indexWhere { case (_, tags) => tags.contains(tagId) } | ||
| val newTrail = if (index >= 0) trail.take(index) else trail | ||
| kont(s ++ restStack, newTrail ++ t1, m1, hs1) // mkont lost here, and it's safe if we never modify it |
There was a problem hiding this comment.
If we replace newTrail to just trail.dropRight(1). nested-strip.wat test is the only one that will fail
ahuoguo
added a commit
that referenced
this pull request
Jan 12, 2025
ahuoguo
added a commit
that referenced
this pull request
Jan 30, 2025
* implemet multi tag, found bug at suspend16 for forgetting meta-continuation * forgor one test * only the control flow structure for failed suspend16 test * push wast file * newMk doesn't work also * push wast file * revert nested resume * some refactor; add test spec * revert accidental change * use the right remaining stack * rebase on Dinghong's version * check point * refactoring * minor refactor * handler * refactor eval, taking only single inst * try catch * rebase Dinghong's tests * some clean up * unify value repr for cont * test case: throw -> resume -> throw -> no resume * initial impl for wasmfx * unreachable not trap * rm redundant case * fix call ref * create tfp only, delete trail, simplify handlers * simplify contV, comment on handler * this brnach only runs tfp, not fx * reflect fix of return_call in #76 * drafting sem for fused eval * rm comment * support for loop Co-authored-by: Jiaaaaatai <[email protected] * first try with return_call.wast * look at return_call.wast failure * even odd had the same problem, ignore ASSERT_INVALID * forgor * rm wasmfx conflictst * both FX and TFP in CI --------- Co-authored-by: ahuoguo <[email protected]> Co-authored-by: butterunderflow <[email protected]> Co-authored-by: Alex Bai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the implementation for wasmfx effect handlers. We added a
Trailin our semantics, which represents the stack of pure clauses forresume.TODO (Dec 18):
not dropping
tagsinnewTrailfailsHandlerto only take inStack