Skip to content

Fix a few typos in the examples #2025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 26, 2022
Merged

Fix a few typos in the examples #2025

merged 11 commits into from
Jul 26, 2022

Conversation

yvonnefroehlich
Copy link
Member

Description of proposed changes

This PR aims to fix a few typos in the examples.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the documentation Improvements or additions to documentation label Jul 25, 2022
@seisman seisman added this to the 0.8.0 milestone Jul 25, 2022
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catches.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Jul 25, 2022
@yvonnefroehlich yvonnefroehlich changed the title Fix a few typos in the examples WIP: Fix a few typos in the examples Jul 25, 2022
@yvonnefroehlich
Copy link
Member Author

Sorry for not adding 'WIP' to the PR title 😕 - I did not expect such a fast review... Thanks @seisman and @michaelgrund 🙂 ! Now I committed all typos which I found while working on PR #2018 😉 .

@yvonnefroehlich yvonnefroehlich changed the title WIP: Fix a few typos in the examples Fix a few typos in the examples Jul 25, 2022
@seisman seisman merged commit f389a4b into GenericMappingTools:main Jul 26, 2022
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jul 26, 2022
@yvonnefroehlich yvonnefroehlich deleted the fix-typos-in-exampels branch July 28, 2022 14:19
@seisman seisman added the skip-changelog Skip adding Pull Request to changelog label Aug 4, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants