Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README about how to download files #54

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

nanjiangshu
Copy link
Contributor

This PR closes #53

Description

  1. Added examples about how to download unencrypted files from the s3 endpoint and encrypted files from the s3-encrypted endpoint.
  2. Fixed also the error in the previous example to download a file from the files endpoint. In the previous one, the downloaded files is named as a BAM file, but actually is a BAI file.

Copy link
Contributor

@pahatz pahatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Contributor

@aaperis aaperis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost works as intended but there was a confusion between .bai and bam files which is fixed in the suggestions.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@MalinAhlberg MalinAhlberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice documentation, @nanjiangshu ! I agree with the suggestion from @aaperis, apart from that I think everything looks good.

Copy link
Contributor

@aaperis aaperis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@aaperis aaperis merged commit b84e74c into main Aug 7, 2024
1 check passed
@aaperis aaperis deleted the feat/update-readme-for-download branch August 7, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the starter-kit documentation
4 participants