fix: update the table building #2327
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilsonjord
reviewed
Jan 20, 2025
| @@ -125,7 +128,7 @@ CREATE TABLE IF NOT EXISTS preamp ( | |||
| preamp_id INTEGER PRIMARY KEY NOT NULL, | |||
| site_id INTEGER NOT NULL, | |||
| subsource TEXT NULL, | |||
| scale_factor REAL DEFAULT 1.0 NOT NULL, | |||
| scale_factor REAL NOT NULL ON CONFLICT REPLACE DEFAULT 1.0, | |||
There was a problem hiding this comment.
question: I'm curious as to how this works; normally would expect to see this on the insert/upsert side.
There was a problem hiding this comment.
sqlite seems to be a bit odd about how it handles defaults and nulls. Normally if you want the default value you simply don't send anything through for that entry, however this becomes painful for large prepared statements (you would need one for every combination of missing data), the above coding can handle the clash of the not null setting and being sent a null value.
This fixes some misconfiguration that resulted in some empty tables, it also cleans up the calling mechanism to build the database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some misconfiguration that resulted in some empty tables, it also cleans up the calling mechanism to build the database