fix(AttachmentsPage): handle application/octet-stream
#1312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #1311
As discovered on the linked issue, Pleroma seems to set supported_mime_types to
application/octet-stream
in an attempt to communicate that everything is supported. However on Tuba, we either use whatever the instance returns or use the built-in list (which is from Mastodon).That means that since Akkoma returns nothing, Tuba internally accepts everything mastodon does. But for Pleroma's case, when the user selects an
image/jpeg
file, Tuba will see thatimage/jpeg
is not in the supported mime types the instance returned which is justapplication/octet-stream
and tuba rejected it silently.This PR makes it so if the only supported mime is
application/octet-stream
then it should be ignored and instead use the internal list.