Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AttachmentsPage): handle application/octet-stream #1312

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

GeopJr
Copy link
Owner

@GeopJr GeopJr commented Jan 27, 2025

fix: #1311

As discovered on the linked issue, Pleroma seems to set supported_mime_types to application/octet-stream in an attempt to communicate that everything is supported. However on Tuba, we either use whatever the instance returns or use the built-in list (which is from Mastodon).

That means that since Akkoma returns nothing, Tuba internally accepts everything mastodon does. But for Pleroma's case, when the user selects an image/jpeg file, Tuba will see that image/jpeg is not in the supported mime types the instance returned which is just application/octet-stream and tuba rejected it silently.

This PR makes it so if the only supported mime is application/octet-stream then it should be ignored and instead use the internal list.

@GeopJr GeopJr merged commit ec5c0d9 into main Jan 27, 2025
4 of 5 checks passed
@GeopJr GeopJr deleted the fix/composer/attachmentpage/pleroma-filetype branch January 27, 2025 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: media won't upload after selecting
1 participant