Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intertidal updates for latest Sandbox image (to merge when released) #84

Merged
merged 11 commits into from
May 10, 2024

Conversation

robbibt
Copy link
Member

@robbibt robbibt commented Apr 23, 2024

This PR makes some minor changes to DEA Intertidal code for compatibility with the latest "unstable" DEA Sandbox image.

Also replaces the pickled Xarray dataset with a NetCDF file as this pickle no longer works with newer version of Xarray/Pandas.

Copy link

For full integration test results, refer to the Tests directory README.

@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.5%. Comparing base (331aac1) to head (83e0a90).

❗ Current head 83e0a90 differs from pull request most recent head 094f893. Consider uploading reports for the commit 094f893 to get more accurate results

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #84   +/-   ##
=====================================
  Coverage   65.5%   65.5%           
=====================================
  Files          8       8           
  Lines        714     714           
=====================================
  Hits         468     468           
  Misses       246     246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robbibt robbibt changed the title Intertidal updates for latest Sandbox image Intertidal updates for latest Sandbox image (to merge when released) Apr 23, 2024
@robbibt robbibt marked this pull request as ready for review May 10, 2024 03:44
@robbibt robbibt requested review from erialC-P and vnewey May 10, 2024 03:44
Copy link
Collaborator

@erialC-P erialC-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @robbibt
That was a lot of work tracking down the updated modules, thanks for doing that!

@erialC-P erialC-P merged commit 00fdde3 into main May 10, 2024
@erialC-P erialC-P deleted the intertidal_updates branch May 10, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants