Update coastal.py #1155
Merged
Update coastal.py #1155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erialC-P
requested review from
robbibt,
BexDunn,
uchchwhash,
Kooie-cate,
geoscience-aman,
JM-GA,
margaretharrison,
vnewey,
Ariana-B,
amanda2099,
supermarkion and
erin-telfer
as code owners
robbibt
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Looks good to me, let's see if it passes tests and merge if it does!
You'll be able to grab the new DEA Tools version number here once it gets merged to develop (and then can update the requirements.in file in dea-intertidal): https://pypi.org/project/dea-tools/#history
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implements a minor change to the _pixel_tides_resample function in coastal.py to enable dataset handling when dask_chunks are no longer associated with the dataset following dask compute.