Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed only four links #1170

Merged
merged 22 commits into from
Jan 8, 2024
Merged

Conversation

benji-glitsos-ga
Copy link
Collaborator

Proposed changes

This PR contains around 22 commits however most of these are commits that I have reverted or are commits that have already been merged to the develop branch. Therefore, you will notice that this PR only changes 4 links which are broken links on the DEA Knowledge Hub, but it maintains them as relative links so they will still work properly on the Sandbox.

Closes issues (optional)

None

Checklist (replace [ ] with [x] to check off)

  • Notebook created using the DEA-notebooks template
  • Remove any unused Python packages from Load packages
  • Remove any unused/empty code cells
  • Remove any guidance cells (e.g. General advice)
  • Ensure that all code cells follow the PEP8 standard for code. The jupyterlab_code_formatter tool can be used to format code cells to a consistent style: select each code cell, then click Edit and then one of the Apply X Formatter options (YAPF or Black are recommended).
  • Include relevant tags in the final notebook cell (refer to the DEA Tags Index, and re-use tags if possible)
  • Clear all outputs, run notebook from start to finish, and save the notebook in the state where all cells have been sequentially evaluated
  • Test notebook on both the NCI and DEA Sandbox (flag if not working as part of PR and ask for help to solve if needed)
  • If applicable, update the Notebook currently compatible with the NCI|DEA Sandbox environment only line below the notebook title to reflect the environments the notebook is compatible with

Benjamin Glitsos added 22 commits December 13, 2023 16:01
… they will open in a tab in the Jupyter Notebook
…toctree now, and replaced them with the sphinx-external-toc tableofcontents directive
…ea-docs toctree now, and replaced them with the sphinx-external-toc tableofcontents directive"

This reverts commit 04fb61c.
…use it is more important that this displays in a new tab properly in the Sandbox. Later I will try to fix this broken link on the dea-docs site
…ustralia/dea-notebooks into feature/fixing-links-jan-2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@erialC-P erialC-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Benji! I think that maintaining the working links in the sandbox is the right call. Hopefully we can find a workaround for the docs :)

@benji-glitsos-ga benji-glitsos-ga merged commit f41432d into develop Jan 8, 2024
1 of 2 checks passed
@benji-glitsos-ga benji-glitsos-ga deleted the feature/fixing-links-jan-2024 branch January 8, 2024 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants