-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed only four links #1170
Merged
Merged
Fixed only four links #1170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Ls to make it consistent
… they will open in a tab in the Jupyter Notebook
…toctree now, and replaced them with the sphinx-external-toc tableofcontents directive
…s git repo now" This reverts commit 307d449.
…ea-docs toctree now, and replaced them with the sphinx-external-toc tableofcontents directive" This reverts commit 04fb61c.
…use it is more important that this displays in a new tab properly in the Sandbox. Later I will try to fix this broken link on the dea-docs site
…ustralia/dea-notebooks into feature/fixing-links-jan-2024
benji-glitsos-ga
requested review from
robbibt,
BexDunn,
erialC-P,
uchchwhash,
Kooie-cate,
geoscience-aman,
JM-GA and
margaretharrison
as code owners
January 8, 2024 01:55
benji-glitsos-ga
requested review from
vnewey,
Ariana-B,
amanda2099,
supermarkion and
erin-telfer
as code owners
January 8, 2024 01:55
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
erialC-P
approved these changes
Jan 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good Benji! I think that maintaining the working links in the sandbox is the right call. Hopefully we can find a workaround for the docs :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR contains around 22 commits however most of these are commits that I have reverted or are commits that have already been merged to the develop branch. Therefore, you will notice that this PR only changes 4 links which are broken links on the DEA Knowledge Hub, but it maintains them as relative links so they will still work properly on the Sandbox.
Closes issues (optional)
None
Checklist (replace
[ ]
with[x]
to check off)Load packages
General advice
)jupyterlab_code_formatter
tool can be used to format code cells to a consistent style: select each code cell, then clickEdit
and then one of theApply X Formatter
options (YAPF
orBlack
are recommended).NCI
andDEA Sandbox
(flag if not working as part of PR and ask for help to solve if needed)Notebook currently compatible with the NCI|DEA Sandbox environment only
line below the notebook title to reflect the environments the notebook is compatible with