Adding DEAfrica Wetland Turbidity notebook for Australian study site #1175
Conversation
Matt-dea
requested review from
robbibt,
BexDunn,
erialC-P,
uchchwhash,
Kooie-cate,
geoscience-aman,
JM-GA,
margaretharrison,
vnewey,
Ariana-B,
amanda2099,
supermarkion and
erin-telfer
as code owners
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Just a heads up, you can review these notebook changes with GitNotebooks too: https://gitnotebooks.com/GeoscienceAustralia/dea-notebooks/pull/1175 I think it offers some advantages over what you're currently using. |
There was a problem hiding this comment.
Hey Matt! Great notebook!
Two requests - can you please go for a small area or add some dask, as this one takes a really long time to run in the standard sandbox, and; can you please add a comment talking about the range of the index and interpreting the results after the first plot? It would be nice to know what the max/min negative/postive values are, and the significance of negative vs. positive values.
I've made a couple of other small changes, to the design, grammar and updated the explorer links and replaced C2 WO summary with C3, and replaced all incidences of NDTI with NDTI2. Hope that makes sense, let me know what you think.
Thanks for doing this, it's looking pretty amazing and it will be great to add it to our repertoire.
* Add updated `xr_regression` function for multi-dimensional linear regression (#1226) * Add updated xr_regression function * Add dask support for lazy computation * Set dtypes * Update docstring * Update docstring * Add MAD outliers * Update docstring * Remove lag functionality * Update docstrings * Add better error handling * Update stream gauge corr notebook to use new func * Adding DEAfrica Wetland Turbidity notebook for Australian study site (#1175) * Adding DEAfrica Wetland Turbidity notebook for Australian study site * change all instances of NDTI to NDTI2 to reflect usage at top of notebook * update notebook to use Collection 3 WO Statistics * rerun notebook --------- Co-authored-by: BexDunn <[email protected]> * Add spatial interpolation with `xr_interpolate` notebook (#1233) * Add ensemble tide modelling functionality to model_tides * Update test_coastal.py * Remove test * Updates to IDW, xr_interpolate and ensemble tide modelling code" * Doco updates * Switch ensemble rankings from high to low = good * Update docstring * Fix doco * Add interpolation notebook * Remove coastal files from branch * Add points data * Review feedback; * Add p param to IDW * Fix test * Updates to product notebook Knowledge Hub links and DEA notebook content (#1221) * Move KH links into consistent alert box format * Update DEA notebook * Minor wording updates * Minor wording * Temporarily remove STAC notebook from tests * Add ensemble tide modelling functionality to `model_tides` (#1231) * Add ensemble tide modelling functionality to model_tides * Update test_coastal.py * Remove test * Updates to IDW, xr_interpolate and ensemble tide modelling code" * Doco updates * Switch ensemble rankings from high to low = good * Update docstring * Fix doco * Add interpolation notebook --------- Co-authored-by: Matt-dea <[email protected]> Co-authored-by: BexDunn <[email protected]>
Proposed changes
Adding a modified version of the DE Africa Wetlands Turbidity notebook using an Australian study site.
Closes issues (optional)
Checklist
(Replace
[ ]with[x]to check off)Load packagesGeneral advice)jupyterlab_code_formattertool can be used to format code cells to a consistent style: select each code cell, then clickEditand then one of theApply X Formatteroptions (YAPForBlackare recommended).NCIandDEA Sandbox(flag if not working as part of PR and ask for help to solve if needed)Notebook currently compatible with the NCI|DEA Sandbox environment onlyline below the notebook title to reflect the environments the notebook is compatible with