Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] Fix error when creating an intervention without a report (suricate workflow) #4347

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

justinefricou
Copy link
Contributor

@justinefricou justinefricou commented Oct 21, 2024

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

cypress bot commented Oct 21, 2024

Geotrek-admin    Run #10156

Run Properties:  status check passed Passed #10156  •  git commit f1cda2ac9f ℹ️: Merge 7da5e4911be10f1265b9dac9a7c82fc9098110f2 into be885a5821c9d12969435fd3070a...
Project Geotrek-admin
Branch Review refs/pull/4347/merge
Run status status check passed Passed #10156
Run duration 02m 04s
Commit git commit f1cda2ac9f ℹ️: Merge 7da5e4911be10f1265b9dac9a7c82fc9098110f2 into be885a5821c9d12969435fd3070a...
Committer Justine Fricou
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@justinefricou justinefricou force-pushed the fix_intervention_status_check branch from f04a46c to cc49e2c Compare October 21, 2024 13:47
geotrek/maintenance/tests/test_forms.py Outdated Show resolved Hide resolved
@justinefricou justinefricou force-pushed the fix_intervention_status_check branch from 5e75529 to 8cde229 Compare October 21, 2024 16:13
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (7d721f0) to head (7da5e49).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4347      +/-   ##
==========================================
- Coverage   98.41%   98.40%   -0.01%     
==========================================
  Files         267      267              
  Lines       20928    20976      +48     
==========================================
+ Hits        20596    20642      +46     
- Misses        332      334       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinefricou justinefricou marked this pull request as ready for review October 21, 2024 16:31
docs/changelog.rst Outdated Show resolved Hide resolved
@submarcos submarcos changed the title 🐛 [BUG] Fix error 500 when creating an intervention without a report (suricate workflow) 🐛 [BUG] Fix error when creating an intervention without a report (suricate workflow) Oct 22, 2024
@justinefricou justinefricou force-pushed the fix_intervention_status_check branch from 130669e to 7da5e49 Compare October 22, 2024 11:47
@justinefricou justinefricou merged commit f49f3c5 into master Oct 22, 2024
24 checks passed
@justinefricou justinefricou deleted the fix_intervention_status_check branch October 22, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants