Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve docker image with labels and manifests #4381

Merged
merged 6 commits into from
Nov 26, 2024
Merged

Improve docker image with labels and manifests #4381

merged 6 commits into from
Nov 26, 2024

Conversation

submarcos
Copy link
Member

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.45%. Comparing base (da30c8c) to head (4174921).
Report is 17 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4381   +/-   ##
=======================================
  Coverage   98.45%   98.45%           
=======================================
  Files         267      267           
  Lines       21107    21107           
=======================================
  Hits        20781    20781           
  Misses        326      326

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress Cypress
Copy link

cypress bot commented Nov 26, 2024 •
edited
Loading

Geotrek-admin    Run #10430

Run Properties:  status check passed Passed #10430  •  git commit 90e870c6ab ℹ️: Merge 4174921302ad94ec100c8d9d94b39e7d80980e43 into 285db1125360085ed853fd724b83...
Project Geotrek-admin
Branch Review refs/pull/4381/merge
Run status status check passed Passed #10430
Run duration 02m 13s
Commit git commit 90e870c6ab ℹ️: Merge 4174921302ad94ec100c8d9d94b39e7d80980e43 into 285db1125360085ed853fd724b83...
Committer Jean-Etienne Castagnede
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@submarcos submarcos marked this pull request as ready for review November 26, 2024 12:38
@submarcos submarcos merged commit 562c814 into master Nov 26, 2024
18 checks passed
@submarcos submarcos deleted the improve_docker_image_2 branch November 26, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
💫 Improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@submarcos